Strip ./ from discover_lintables results #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebix
requested review from
relrod,
cidrblock and
priyamsahoo
and removed request for
a team
sebix
force-pushed
the
fix_test_discover_lintables_umlaut
branch
2 times, most recently
from
94ec64a
to
fadda4a
Compare
I'm not sure what's the best way to make mypy happy. |
ssbarnea
changed the title
ssbarnea
approved these changes
Feb 1, 2022
ssbarnea
changed the title
felixfontein
reviewed
Feb 1, 2022
auto-merge was automatically disabled
February 1, 2022 18:52
Head branch was pushed to by a user without write access
sebix
force-pushed
the
fix_test_discover_lintables_umlaut
branch
from
d299190
to
2a900ef
Compare
|
Thanks for the feedback. I refactored the code as suggested with a separate function and a set comprehension. That also obsoleted the import of |
felixfontein
reviewed
Feb 1, 2022
sebix
force-pushed
the
fix_test_discover_lintables_umlaut
branch
from
5155d8e
to
116015f
Compare
Now rebase on updated main. Looks better :) |
felixfontein
approved these changes
Feb 1, 2022
calling WcMatch('.', ...) causes the resulting file names to be prefixed
with `./`.
If the tests are run in a git-repository, this is not an issue, as git
is preferred of WcMatch in the code.
Therefore remove the `./` prefix from the WcMatch return value to get
the identical expected output.
fixes ansible#1836
sebix
force-pushed
the
fix_test_discover_lintables_umlaut
branch
from
116015f
to
f881ebf
Compare
|
... and now also fixed this check fail: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
calling WcMatch('.', ...) causes the resulting file names to be prefixed
with
./.If the tests are run in a git-repository, this is not an issue, as git
is preferred of WcMatch in the code.
Therefore remove the
./prefix from the WcMatch return value to getthe identical expected output.
fixes #1836