-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MatchError's should include the filename #1806
Conversation
These rules do not provide linenumber because identifying the line would be fiddly or misleading:
|
I also used the |
cf13cb8
to
c84cedb
Compare
rebased on main |
c84cedb
to
6df3548
Compare
@cognifloyd Please search for |
Yup. I searched for |
The other instances of |
Here are the other uses of the string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @cognifloyd, for your contribution!
Whenever possible, we should include the filename and linenumber in the MatchError.
I also used the
LINE_NUMBER_KEY
const var instead of using"__line__"
.This is minor and should not impact anyone now, but it makes fixing identified errors easier in #1805 (this was extracted from that PR).