-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add progressive mode #1065
Add progressive mode #1065
Conversation
2b0387c
to
5ee4d6d
Compare
If I have 5 errors of type A, fix them in one commit but create 4 new errors of type B in that fix, will this fail (since I introduced 4 new errors) or pass (since only 4 errors are now in the repository, even though they are new)? |
5ee4d6d
to
67b4342
Compare
I rewrote a lot of the implementation and now it will always fail if newer violations are introduced. Take a look and more important, test locally. |
This is an interesting feature, for sure—though the first run of Ansible Lint on an existing repo would fail, correct? Or I guess if it runs against a commit that had no new violations compared to the previous commit, then it wouldn't fail. It would be useful for those who are adopting Ansible Lint on a repo that has a lot of history and needs a lot of cleanup. |
Adds a new option --progressive that ease adoption of the linter as it will only report failure if it detects an increase number of violations since previous commit.
67b4342
to
1eb9e1c
Compare
Adds a new option --progressive that ease adoption of the linter as it will only report failure if it detects an increase number of violations since previous commit.
An example of the output when run in progressive mode can be seen below: