Allow use of file key inside include_tasks #1020
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an already closed but not really fixed issue.
As outlined in #507 (comment) the following example causes an error:
Error output (taken from the comment):
The actual issue here is not the apply statement. It just causes ansible-lint to crash while without it ansible-lint silently behaves strangely.
The root cause is that ansible-lint always expects a single string value for include_tasks.
As seen in the example that is not always the case.
I fixed that by checking for a dict value and extracting its file value for further processing.
Also I expanded an existing test case to cover this kind of include_tasks.
Fixes: #507