Remove meta-no-info rule due to being covered by schema[meta] (#3267)

ansible · Apr 12, 2023 · 2a787ab · 2a787ab
1 parent 96d1914
commit 2a787ab
Show file tree

Hide file tree

Showing 15 changed files with 7 additions and 216 deletions.
diff --git a/.github/workflows/tox.yml b/.github/workflows/tox.yml
@@ -59,7 +59,7 @@ jobs:
       WSLENV: FORCE_COLOR:PYTEST_REQPASS:TOXENV:GITHUB_STEP_SUMMARY
       # Number of expected test passes, safety measure for accidental skip of
       # tests. Update value if you add/remove tests.
-      PYTEST_REQPASS: 797
+      PYTEST_REQPASS: 793
     steps:
       - name: Activate WSL1
         if: "contains(matrix.shell, 'wsl')"

diff --git a/docs/profiles.md b/docs/profiles.md
@@ -83,7 +83,6 @@ private instance. It extends [safety](#safety) profile.
 - [ignore-errors](rules/ignore-errors.md)
 - [layout](https://github.com/ansible/ansible-lint/issues/1900)
 - [meta-incorrect](rules/meta-incorrect.md)
-- [meta-no-info](rules/meta-no-info.md)
 - [meta-no-tags](rules/meta-no-tags.md)
 - [meta-video-links](rules/meta-video-links.md)
 - [meta-version](https://github.com/ansible/ansible-lint/issues/2103)

diff --git a/docs/redirects.yml b/docs/redirects.yml
@@ -7,6 +7,10 @@
 - type: page
   from_url: /rules/hg-latest/
   to_url: /rules/latest/
+- type: page
+  from_url: /rules/meta-no-info/
+  # cspell:disable-next-line
+  to_url: /rules/schemas/#schemameta
 - type: page
   from_url: /rules/deprecated-command-syntax/
   to_url: /rules/no-free-form/

diff --git a/docs/rules/index.md b/docs/rules/index.md
@@ -20,7 +20,6 @@
 - [load-failure][]
 - [loop-var-prefix][]
 - [meta-incorrect][]
-- [meta-no-info][]
 - [meta-no-tags][]
 - [meta-runtime][]
 - [meta-video-links][]

diff --git a/docs/rules/meta-no-info.md b/docs/rules/meta-no-info.md
diff --git a/examples/roles/meta_noqa/meta/main.yml b/examples/roles/meta_noqa/meta/main.yml
@@ -1,7 +1,7 @@
 ---
 galaxy_info: # noqa: meta-incorrect
   standalone: true
-  author: your-name # noqa: meta-no-info
+  author: your-name
   description: missing min_ansible_version and platforms. author default not changed
   license: MIT
   min_ansible_version: "2.10"

diff --git a/mkdocs.yml b/mkdocs.yml
@@ -75,7 +75,6 @@ nav:
       - rules/load-failure.md
       - rules/loop-var-prefix.md
       - rules/meta-incorrect.md
-      - rules/meta-no-info.md
       - rules/meta-no-tags.md
       - rules/meta-runtime.md
       - rules/meta-video-links.md

diff --git a/src/ansiblelint/constants.py b/src/ansiblelint/constants.py
@@ -97,7 +97,6 @@ def main():
     "505": "missing-import",
     "601": "literal-compare",
     "602": "empty-string-compare",
-    "701": "meta-no-info",
     "702": "meta-no-tags",
     "703": "meta-incorrect",
     "704": "meta-video-links",

diff --git a/src/ansiblelint/data/profiles.yml b/src/ansiblelint/data/profiles.yml
@@ -78,7 +78,6 @@ shared:
     layout:
       url: https://github.com/ansible/ansible-lint/issues/1900
     meta-incorrect:
-    meta-no-info:
     meta-no-tags:
     meta-video-links:
     meta-version:

diff --git a/src/ansiblelint/rules/meta_no_info.md b/src/ansiblelint/rules/meta_no_info.md
diff --git a/src/ansiblelint/rules/meta_no_info.py b/src/ansiblelint/rules/meta_no_info.py
diff --git a/src/ansiblelint/schemas/ansible-lint-config.json b/src/ansiblelint/schemas/ansible-lint-config.json
@@ -149,7 +149,6 @@
               "literal-compare",
               "load-failure",
               "meta-incorrect",
-              "meta-no-info",
               "meta-no-tags",
               "meta-runtime",
               "meta-video-links",

diff --git a/test/rules/test_meta_no_info.py b/test/rules/test_meta_no_info.py
diff --git a/test/schemas/negative_test/.ansible-lint.md b/test/schemas/negative_test/.ansible-lint.md
@@ -32,7 +32,6 @@
         "literal-compare",
         "load-failure",
         "meta-incorrect",
-        "meta-no-info",
         "meta-no-tags",
         "meta-runtime",
         "meta-video-links",

diff --git a/test/test_rules_collection.py b/test/test_rules_collection.py
@@ -166,5 +166,5 @@ def test_rules_id_format() -> None:
             rule.help != "" or rule.description or rule.__doc__
         ), f"Rule {rule.id} must have at least one of:  .help, .description, .__doc__"
     assert "yaml" in keys, "yaml rule is missing"
-    assert len(rules) == 50  # update this number when adding new rules!
+    assert len(rules) == 49  # update this number when adding new rules!
     assert len(keys) == len(rules), "Duplicate rule ids?"