Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use env variables instead of passing unsafe text to the workflow script #5023

Merged
merged 2 commits into from
May 6, 2024
Merged

Use env variables instead of passing unsafe text to the workflow script #5023

merged 2 commits into from
May 6, 2024

Conversation

jctanner
Copy link
Contributor

@jctanner jctanner commented May 6, 2024

jctanner added 2 commits May 6, 2024 15:50
@jctanner
Use environment variables instead of passing unsafe text to the workf…
8dea35a 
…low script.

No-Issue

Signed-off-by: James Tanner <tanner.jc@gmail.com>
@jctanner
Duplicate env keys.
85484eb 
No-Issue

Signed-off-by: James Tanner <tanner.jc@gmail.com>
@jctanner jctanner merged commit 6116e76 into ansible:master May 6, 2024
12 of 13 checks passed
@himdel himdel added the backport-4.9 This PR should be backported to stable-4.9 (2.4) label May 7, 2024
@patchback Patchback
Copy link

patchback bot commented May 7, 2024 •
edited
Loading

Backport to stable-4.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.9/6116e7600a934818ddfb085f1ac819018f1214e6/pr-5023

Backported as #5024

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 7, 2024
@jctanner @patchback
Use env variables instead of passing unsafe text to the workflow scri…
5f7429c 
…pt (#5023)

* Use environment variables instead of passing unsafe text to the workflow script.

No-Issue

Signed-off-by: James Tanner <tanner.jc@gmail.com>
(cherry picked from commit 6116e76)
@patchback patchback bot mentioned this pull request May 7, 2024
Merged
@himdel himdel added the backport-4.6 This PR should be backported to stable-4.6 (2.3) label May 7, 2024
@patchback Patchback
Copy link

patchback bot commented May 7, 2024 •
edited
Loading

Backport to stable-4.6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.6/6116e7600a934818ddfb085f1ac819018f1214e6/pr-5023

Backported as #5025

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 7, 2024
@jctanner @patchback
Use env variables instead of passing unsafe text to the workflow scri…
c034619 
…pt (#5023)

* Use environment variables instead of passing unsafe text to the workflow script.

No-Issue

Signed-off-by: James Tanner <tanner.jc@gmail.com>
(cherry picked from commit 6116e76)
@patchback patchback bot mentioned this pull request May 7, 2024
Merged
himdel pushed a commit that referenced this pull request May 8, 2024
@patchback @jctanner
Use env variables instead of passing unsafe text to the workflow scri…
ec887e1 
…pt (#5023) (#5025)

* Use environment variables instead of passing unsafe text to the workflow script.

No-Issue

Signed-off-by: James Tanner <tanner.jc@gmail.com>
(cherry picked from commit 6116e76)

Co-authored-by: jctanner <tanner.jc@gmail.com>
@github-actions github-actions bot added the backported-4.6 This PR has been backported to stable-4.6 (2.3) label May 8, 2024
himdel pushed a commit that referenced this pull request May 8, 2024
@patchback @jctanner
Use env variables instead of passing unsafe text to the workflow scri…
9c32615 
…pt (#5023) (#5024)

* Use environment variables instead of passing unsafe text to the workflow script.

No-Issue

Signed-off-by: James Tanner <tanner.jc@gmail.com>
(cherry picked from commit 6116e76)

Co-authored-by: jctanner <tanner.jc@gmail.com>
@github-actions github-actions bot added the backported-4.9 This PR has been backported to stable-4.9 (2.4) label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drodowic drodowic drodowic approved these changes

@bmclaughlin bmclaughlin bmclaughlin approved these changes

@himdel himdel Awaiting requested review from himdel

@MilanPospisil MilanPospisil Awaiting requested review from MilanPospisil

@sivel sivel Awaiting requested review from sivel

@rochacbruno rochacbruno Awaiting requested review from rochacbruno

@chr-stian chr-stian Awaiting requested review from chr-stian

Assignees
No one assigned
Labels
backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.9 This PR should be backported to stable-4.9 (2.4) backported-4.6 This PR has been backported to stable-4.6 (2.3) backported-4.9 This PR has been backported to stable-4.9 (2.4)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jctanner @bmclaughlin @drodowic @himdel