tests: switch to uv pip-compile for lockfiles #2084
Conversation
|
@gotmax23 Just checking but did you mark the other PRs to update dependencies as draft pending this one? |
|
No, they were marked as draft because they were generated using the broken version of pip-tools. I'll check them again so they can be merged in the interim (and also rebase this PR) later. Thanks! |
|
This is still on my radar. I've just been very busy. Thanks everyone for your feedback so far. |
gotmax23
force-pushed
the
uv-pip-compile
branch
from
2f626e5 to
bf7b367
Compare
gotmax23
force-pushed
the
uv-pip-compile
branch
from
44ae1df to
95cc63e
Compare
|
Ready for review |
Can you elaborate? |
|
@gotmax23 FYI there's now a conflict with the static requirements file. If you could fix that I think we can go ahead and merge. I believe @webknjaz is on PTO and might not respond until later. Probably no need to hold up the merge. @felixfontein If you could also provide a final review, that'd be appreciated. Thanks! |
Incompatibilities with some platform might be included. I heard they're using Poetry-style lock file ish method, which is known to have this weakness. |
This switches the nox pip-compile session and lockfiles to use uv pip compile (written in Rust and much faster) instead of pip-compile from pip-tools for our dependency update jobs. As a side effect, this addresses the issue brought up in ansible#1950 (comment), as we're no longer using pip-compile that can break anytime pip changes the private/internal APIs that pip-tools relies on. I re-generated the lockfiles with `--no-upgrade` to avoid extraneous changes in this PR. The only additions are the formatting of comments in the lockfile and colorama. colorama was added as a result of `uv pip-compile`'s `--universal` flag which creates "universal" lockfiles that include dependencies of other platforms, architectures, and Python versions than those of the system used to generate the lockfile. `--universal` should create more consistent results for contributors who use other systems (e.g., Mac OS or a newer Python version than the one used in CI). Fixes: ansible#1755
Suggested-by: Don Naro <dnaro@redhat.com>
gotmax23
force-pushed
the
uv-pip-compile
branch
from
95cc63e to
5fc33b7
Compare
|
@gotmax23 I think it's time to merge this. How far do you think we should backport? Or maybe we keep it on devel until we cut stable-2.19? Thanks! 🚀 |
This switches the nox pip-compile session and lockfiles to use uv pip compile (written in Rust and much faster) instead of pip-compile from pip-tools for our dependency update jobs.
As a side effect, this addresses the issue brought up in #1950 (comment), as we're no longer using pip-compile that can break anytime pip changes the private/internal APIs that pip-tools relies on.
I re-generated the lockfiles with
--no-upgradeto avoid extraneous changes in this PR.The only additions are the formatting of comments in the lockfile and colorama.
colorama was added as a result of
uv pip-compile's--universalflag which creates "universal" lockfiles that include dependencies of other platforms, architectures, and Python versions than those of the system used to generate the lockfile.--universalshould create more consistent results for contributors who use other systems(e.g., Mac OS or a newer Python version than the one used in CI).
Fixes: #1755