Inject venv site-packages at the top of collection path (test isolation) #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
added a commit
to ansible/ansible-lint
that referenced
this pull request
Jan 20, 2025
This was needed for implementing ansible/ansible-compat#447
ssbarnea
added a commit
to ansible/ansible-lint
that referenced
this pull request
Jan 20, 2025
This bug caused some testing failures in a very limited use scenarios. Related: ansible/ansible-compat#447
ssbarnea
changed the title
ssbarnea
changed the title
ssbarnea
changed the title
Closed
- Inject venv site-packages into collection patch in order to ensure that by default ansible-galaxy commands will install content in these instead of user configuration. (test isolation) - Adapt smoke testing to test both molecule and ansible-lint, which before this change would have failed one test.
audgirka
approved these changes
Jan 27, 2025
Qalthos
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ansible-galaxy installcommand, one that would have installed requirements it another location.Fixes: AAP-38731
Reference: https://ansible.readthedocs.io/projects/dev-tools/user-guide/test-isolation/