Increase test coverage #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
commented
Jul 27, 2021
| def test_require_collection_preexisting_broken(tmp_path: pathlib.Path) -> None: | ||
| """Check that require_collection raise with broken pre-existing collection.""" | ||
| runtime = Runtime(isolated=True, project_dir=str(tmp_path)) | ||
| dest_path: str = runtime.config.collections_path[0] # type: ignore |
There was a problem hiding this comment.
@webknjaz (line 381) apparently even with our type hints added to Config class, mypy still believes that any Config.attribute is of type object.
I am not pleased about this dirty trick because it means that this would be expected from consumers of this library too. Any idea on how to avoid that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.