Fix standalone role bootstrapping #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ssbarnea
commented
Jul 24, 2021
•
ssbarnea
commented
- Fixes a bug introduce when we added support for project_dir and we still continued to rely on CWD in few places.
- Adds tests for covering this use-case
ssbarnea
force-pushed
the
fix/api
branch
6 times, most recently
from
afb37ae to
a6504ba
Compare
ssbarnea
force-pushed
the
fix/api
branch
2 times, most recently
from
efe89e2 to
76372f4
Compare
webknjaz
reviewed
Jul 25, 2021
src/ansible_compat/runtime.py
Outdated
| @@ -122,6 +122,7 @@ def exec(self, args: Union[str, List[str]]) -> CompletedProcess: | |||
| check=False, | |||
| stdout=subprocess.PIPE, | |||
| stderr=subprocess.PIPE, | |||
| env=os.environ, | |||
There was a problem hiding this comment.
This happens by default. Why did you add it?
.gitmodules
Outdated
| @@ -0,0 +1,3 @@ | |||
| [submodule "test/assets/ansible-role-mysql"] | |||
There was a problem hiding this comment.
It'd go for git subtree or put the synching logic into the pytest setup. Making the contributors do this is fragile.
|
There is a lot of debugging junk i need to remove. I think I found the culprit yesterday, mainly submodules cloning no longer works with checkout v2. Instead I will just create a mini embedded role for testing. |
ssbarnea
force-pushed
the
fix/api
branch
2 times, most recently
from
293a6c8 to
914db58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.