Declare Java Heap options as variables #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rmarting please review and let me know if you see any issue! |
rmarting
suggested changes
Jul 18, 2023
There was a problem hiding this comment.
@rpelisse I am only missing the declaration of the default values for each component, as it is only declared in the zookeeper role. I pushed another PR #50 (as extension of this one) with a set of commits to declare the defaults and the documentation.
Could you add these commits into this PR before merging into the main branch?
With that extension, this PR LGTM.
|
Tested successfully in this PR the #17. So, it is allowed to install offline the Kafka connect cluster. |
Merged
rpelisse
added
the
minor_changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31