Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add box_architecture config to parameters #284

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

karcaw
Copy link
Contributor

@karcaw karcaw commented Nov 13, 2024

Vagrant recently added a box_architecture flag, which defaults to the current platform, which breaks my need to test amd64 images on a M2/3/4-based MacOS device. This patch adds the glue needed to pass the required architecture down to the lower-level VagrantFile

For reference:
hashicorp/vagrant@51adb12

@karcaw
Copy link
Contributor Author

karcaw commented Nov 17, 2024

I dont seem to have access to add the labels, can someone add 'enhancement' please.

Copy link
Member

@apatard apatard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My version of vagrant doesn't support this option but the commit doesn't regress the vagrant plugin test suite and is looking fine. So, let's get this merged.

@apatard apatard merged commit 926974b into ansible-community:main Dec 20, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vagrant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants