Skip to content
This repository has been archived by the owner on Jan 5, 2023. It is now read-only.

Fix to support logging into a Windows Container #40

Closed
wants to merge 3 commits into from
Closed

Fix to support logging into a Windows Container #40

wants to merge 3 commits into from

Conversation

tmeckel
Copy link

@tmeckel tmeckel commented Mar 1, 2021

This PR contains a small addition to driver.pyto be able to login into a Windows Container.

Related to: ansible-collections/community.docker#96

@tmeckel
Copy link
Author

tmeckel commented Mar 2, 2021

@ssbarnea as @chrisjsewell I'm wondering about the errors in the pipeline and ask, if the tests are just broken.

@ssbarnea
Copy link
Member

ssbarnea commented Mar 2, 2021

I am sure somethings are broken on CI and I hope someone will attempt to fix them. I am unable to do it myself but I will help with review and release. It is not uncommon to have to fix 2-3 other issues before you make you patch mergeable on open-source projects. :p ... not ideal, but the sad reality.

@tmeckel
Copy link
Author

tmeckel commented Mar 2, 2021

@ssbarnea Issue is that I even can't run tox locally in the master branch with success.

On issue that I spotted easily was the fact that the repo does not contain a docs folder so that the tox tests testenv:docs and testenv:docs-livereload fail. So I removed those test from tox.ini for testing.

@tmeckel
Copy link
Author

tmeckel commented Mar 2, 2021

@ssbarnea The tox tests pass on my machine (except the ones for python 3.7, 3.8, 3.9 because I don't have those versions installed) but the pipeline is failed with the following error:

image

So I suspect Ansible isn't correctly installed in the CI pipeline.

Although it should be installed according to the pipeline definition

image

@ssbarnea ssbarnea added the stale Not updated in long time, will be closed soon. label Apr 14, 2021
@ssbarnea
Copy link
Member

I will close it as until ansible-collections/community.docker#96 is merged and released we cannot do anything about it.

@ssbarnea ssbarnea closed this Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stale Not updated in long time, will be closed soon.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants