-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/improve version_added #34
Fix/improve version_added #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, for curiosity sake, do you happen have rendered output to see the differences?
Yes, see the above links :) |
I wonder whether I should add special code to write |
…ead of '2.x of ansible-core'.
🤦♂️ in my defense, I am not usually up this early
It seems you just pushed the commit. I was going to say "nah don't bother since they're EoL" but I realize now that the version added stuff will stay as long as those things haven't since been updated, so I think it's nice. And since it's already done, no need to remove it. |
@briantist I also updated the built docs, so if you're happy I'll merge :) |
Hm I have one possible English nit:
To me it feels slightly unnatural, but it feels natural to say any of
It's not a big enough thing for me to block over, and I'm also sensitive to screen real-estate for the text. Maybe get some other opinions on that. |
How about |
The docsite is now updated. See https://ansible.fontein.de/collections/community/crypto/crypto_info_module.html#ansible-collections-community-crypto-crypto-info-module for another example (module's version_added). |
@briantist thanks for reviewing this! |
Fix escaping and collection names in roles options, and make it say
added in version 2.11 of ansible-core
instead ofadded in version 2.11 of ansible.builtin
.Examples: