Convert collection links from raw HTML to directive #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 20, 2023
felixfontein
force-pushed
the
latex-indent-styling-links
branch
2 times, most recently
from
58cf15f to
41d8feb
Compare
felixfontein
changed the title
felixfontein
force-pushed
the
latex-indent-styling-links
branch
from
41d8feb to
86c2c05
Compare
oraNod
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
LGTM. Some really minor nits on wording. I couldn't find any faults or optimizations for the code side but I did look and it all seems fine. I think this is really nice work @felixfontein
Co-authored-by: Don Naro <dnaro@redhat.com>
Co-authored-by: Don Naro <dnaro@redhat.com>
|
@oraNod thanks a lot for reviewing this and improving the formulations :) |
you're welcome. thanks for all your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently includes
#195,#198, and #199. Will rebase once these are merged.Converts the inline HTML for collection links to a custom directive. The external links are a custom nodes class inherited from docutils's
referencewith a custom HTML generator; for other builders, thereferencegenerator provided by that builder is used (so in LaTeX it is a regular hyperlink reference). The "Communication" button though needs a Sphinxpending_xrefnode (to resolve the reference), which improves on the previous version by not relying on implementation details, but at the same time is worse than before becausepending_xrefis replaced by a plainref(Sphinx doesn't allow to customize this), which rendered to HTML neither hastarget="_blank"noraria-role="button". (Aside from that, it looks and behaves like a button, though.)The HTML output didn't change (except the missing attributes for the "Communication" button, which you cannot see here):
The LaTeX output is now as expected - the first four buttons are hyperlinks, the last one an internal reference in the PDF file:
