Switch to hatchling, and requiring Python 3.9+ #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
felixfontein
force-pushed
the
hatch
branch
5 times, most recently
from
38a5322 to
7954841
Compare
felixfontein
changed the title
gotmax23
reviewed
Apr 7, 2023
There was a problem hiding this comment.
Should we move this to an integration nox target?
There was a problem hiding this comment.
I first wanted to do that, but than decided to not do it in this PR since it is a quite extensive job, and also there would be five different targets and not just one (you really want to run them in parallel since they take a long time).
There was a problem hiding this comment.
nox supports parametrizing sessions which would make this easier, but yeah, I think it's reasonable to do that separately.
Co-authored-by: Maxwell G <maxwell@gtmx.me>
gotmax23
reviewed
Apr 8, 2023
Co-authored-by: Maxwell G <maxwell@gtmx.me>
Co-authored-by: Maxwell G <maxwell@gtmx.me>
felixfontein
commented
Apr 8, 2023
gotmax23
approved these changes
Apr 8, 2023
|
@gotmax23 thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.