replace t_systems_mms with telekom_mms #261

rndmh3ro · 2023-07-12T14:48:05Z

We renamed our company and thus the collection-namespace here: ansible/galaxy#3174

The collection now lives here: https://github.com/telekom-mms/ansible-collection-icinga-director

I released a new major version 2.0.0 in the old namespace (https://galaxy.ansible.com/t_systems_mms/icinga_director) where I added the plugin-routing to the new namespace. I also deprecated the collection in the galaxy.

This way I hope in Ansible 8 the old collection will stay the same while in Ansible 9 the new collection will be used.

mariolenz

This isn't 100% according to the renaming a collection process.

As far as I understand, the new collection t_systems_mms.icinga_director should be added to Ansible 8. t_systems_mms.icinga_director 2.0.0 would still be contained in the Ansible community package 9 and removed from 10.

Have a look at #126. It didn't work out as expected, but I think it's a good starting point.

rndmh3ro · 2023-07-13T11:00:31Z

Thanks @mariolenz, I didn't know about the docs you linked to.

I hope I've done everything right, now.

mariolenz

LGTM at the moment, but I'll ask some people if I'm right.

gotmax23 · 2023-07-13T15:47:51Z

Our CI is currently failing with:

t_systems_mms.icinga_director 2.0.0 is not tagged in https://github.com/T-Systems-MMS/ansible-collection-icinga-director

Please fix the issue so that the collection complies with the repository management section of the Collection Requirements:

Every collection MUST have a public git repository. Releases of the collection MUST be tagged in said repository. This means that releases MUST be git taged and that the tag name MUST exactly match the Galaxy version number. Tag names MAY have a v prefix, but a collection's tag names MUST have a consistent format from release to release.

Additionally, collection artifacts released to Galaxy MUST be built from the sources that are tagged in the collection's git repository as that release. Any changes made during the build process MUST be clearly documented so the collection artifact can be reproduced.

mariolenz · 2023-07-13T16:40:57Z

Thanks @gotmax23, I didn't spot that!

@rndmh3ro It looks like you've moved and redirected https://github.com/T-Systems-MMS/ansible-collection-icinga-director to https://github.com/telekom-mms/ansible-collection-icinga-director and this causes some trouble. I think it would have been easier to keep t_systems_mms.icinga_director in T-Systems-MMS, deprecate it there and tag it with 2.0.0.

rndmh3ro · 2023-07-14T06:55:14Z

@rndmh3ro It looks like you've moved and redirected https://github.com/T-Systems-MMS/ansible-collection-icinga-director to https://github.com/telekom-mms/ansible-collection-icinga-director and this causes some trouble. I think it would have been easier to keep t_systems_mms.icinga_director in T-Systems-MMS, deprecate it there and tag it with 2.0.0.

But how would I then move it and also publish a telem_mms.icinga_director version 2.0.0?

I don't know how to fix this whole mess. :)

felixfontein · 2023-07-14T18:40:28Z

I've created #264 to ignore the tag error.

The 2.0.0 release seems to have some more problems, for example the deprecation is done only in meta/runtime.yml, but not in the modules themselves. This means that the deprecation is completely invisible for Ansible 2.9, and that it will not be visible on the docsite. Also the inventory plugin hasn't been deprecated. There's also no changelog entry for 2.0.0.

felixfontein · 2023-07-14T18:41:54Z

9/changelog.yaml

+      deprecated_features:
+        - The collection ``t_systems_mms.icinga_director`` has been renamed to ``telekom_mms.icinga_director``.
+            For now both collections are included in Ansible. The content in ``t_systems_mms.icinga_director``
+            will be replaced with deprecated redirects to the new collection in Ansible 9.0.0,


Suggested change

will be replaced with deprecated redirects to the new collection in Ansible 9.0.0,

have been replaced with deprecated redirects to the new collection in Ansible 9.0.0,

felixfontein · 2023-07-14T18:42:19Z

9/changelog.yaml

+        - The collection ``t_systems_mms.icinga_director`` has been renamed to ``telekom_mms.icinga_director``.
+            For now both collections are included in Ansible. The content in ``t_systems_mms.icinga_director``
+            will be replaced with deprecated redirects to the new collection in Ansible 9.0.0,
+            and these redirects will eventually be removed from Ansible. Please update your


Let's fix a version when this will happen:

Suggested change

and these redirects will eventually be removed from Ansible. Please update your

and these redirects will be removed from Ansible 11. Please update your

rndmh3ro · 2023-07-17T06:33:56Z

The 2.0.0 release seems to have some more problems, for example the deprecation is done only in meta/runtime.yml, but not in the modules themselves. This means that the deprecation is completely invisible for Ansible 2.9, and that it will not be visible on the docsite. Also the inventory plugin hasn't been deprecated. There's also no changelog entry for 2.0.0.

Thanks, @felixfontein. I'll try to fix these. Should I release a 2.0.1 in Galaxy for the fixes?

felixfontein · 2023-07-18T08:26:55Z

@rndmh3ro that would probably be better, especially the changelog will be useful for Ansible 9.0.0 since the information will then show up in its combined changelog.

mariolenz · 2023-07-18T16:24:56Z

@rndmh3ro It looks like there are some conflicts that must be resolved. Can you please rebase? I guess this is because of the changes to changelog.yaml in #262, #269 and #271.

I'm not 100% sure, but you'll see when you actually do the rebase.

rndmh3ro · 2023-07-20T12:57:58Z

@felixfontein, I now forked the collection from the new namespace to the old one and created the following PR:
T-Systems-MMS/ansible-collection-icinga-director#1

If this PR can be merged, I'll do this. Then I'll release a 2.0.1 in the old collection. Then I'll update the build-data.
Is this the correct way?

mariolenz · 2023-07-20T14:53:38Z

I'm really sorry, but we've just released 8.2.0. Could you please rebase your PR an move the deprecation to 8.3.0?

BTW there are two suggested changes, could you please have a look at them?

I now forked the collection from the new namespace to the old one and created the following PR: T-Systems-MMS/ansible-collection-icinga-director#1

If this PR can be merged, I'll do this. Then I'll release a 2.0.1 in the old collection. Then I'll update the build-data. Is this the correct way?

@felixfontein What do you think about this, would it help?

We renamed our company and thus the collection-namespace here: ansible/galaxy#3174 The collection now lives here: https://github.com/telekom-mms/ansible-collection-icinga-director I released a new major version 2.0.0 in the old namespace (https://galaxy.ansible.com/t_systems_mms/icinga_director) where I added the plugin-routing to the new namespace. I also deprecated the collection in the galaxy. This way I hope in Ansible 8 the old collection will stay the same while in Ansible 9 the new collection will be used. complete process for icinga_director deprecation

rndmh3ro · 2023-07-21T03:50:19Z

I rebased and updated the PR with the suggestions.

rndmh3ro · 2023-07-21T12:02:04Z

And I also released a 2.0.1 of the old collection, hopefully doing everything right.

When running a playbook with the old modules in version 2.0.1, I get:

[DEPRECATION WARNING]: t_systems_mms.icinga_director.icinga_serviceset has been deprecated. Use telekom_mms.icinga_director.icinga_serviceset instead. This feature will be removed from
t_systems_mms.icinga_director in version 3.0.0. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.

felixfontein · 2023-07-21T13:31:34Z

CI should be fixed by #273.

felixfontein · 2023-07-21T13:40:15Z

Restart CI.

mariolenz · 2023-07-23T19:19:22Z

@felixfontein Since you've approved and the CI seems to be happy, I've squashed and merged.

Please let me know if you think this has been a mistake. I'll undo in this case.

felixfontein · 2023-07-23T19:26:16Z

No, everything is fine! Thanks everyone for getting this done!

mariolenz requested changes Jul 12, 2023

View reviewed changes

rndmh3ro force-pushed the patch-1 branch from 328ffd2 to 48eadc6 Compare July 13, 2023 10:58

mariolenz approved these changes Jul 13, 2023

View reviewed changes

rndmh3ro mentioned this pull request Jul 14, 2023

[Bug] Release 1.33.2 is published to ansible galaxy as version 2.0.0 and when used gives the following error: couldn't resolve module/action 't_systems_mms.icinga_director.icinga_host_info' telekom-mms/ansible-collection-icinga-director#217

Closed

felixfontein reviewed Jul 14, 2023

View reviewed changes

rndmh3ro force-pushed the patch-1 branch from 48eadc6 to 98c015f Compare July 21, 2023 03:49

felixfontein approved these changes Jul 21, 2023

View reviewed changes

felixfontein mentioned this pull request Jul 21, 2023

9: remove no longer necessary ignore #273

Merged

felixfontein closed this Jul 21, 2023

felixfontein reopened this Jul 21, 2023

mariolenz merged commit e53165a into ansible-community:main Jul 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

replace t_systems_mms with telekom_mms #261

replace t_systems_mms with telekom_mms #261

rndmh3ro commented Jul 12, 2023

mariolenz left a comment

rndmh3ro commented Jul 13, 2023

mariolenz left a comment

gotmax23 commented Jul 13, 2023

mariolenz commented Jul 13, 2023

rndmh3ro commented Jul 14, 2023

felixfontein commented Jul 14, 2023

felixfontein Jul 14, 2023

felixfontein Jul 14, 2023

rndmh3ro commented Jul 17, 2023

felixfontein commented Jul 18, 2023

mariolenz commented Jul 18, 2023

rndmh3ro commented Jul 20, 2023

mariolenz commented Jul 20, 2023

rndmh3ro commented Jul 21, 2023

rndmh3ro commented Jul 21, 2023

felixfontein commented Jul 21, 2023

felixfontein commented Jul 21, 2023

mariolenz commented Jul 23, 2023

felixfontein commented Jul 23, 2023

	will be replaced with deprecated redirects to the new collection in Ansible 9.0.0,
	have been replaced with deprecated redirects to the new collection in Ansible 9.0.0,

	and these redirects will eventually be removed from Ansible. Please update your
	and these redirects will be removed from Ansible 11. Please update your

replace t_systems_mms with telekom_mms #261

replace t_systems_mms with telekom_mms #261

Conversation

rndmh3ro commented Jul 12, 2023

mariolenz left a comment

Choose a reason for hiding this comment

rndmh3ro commented Jul 13, 2023

mariolenz left a comment

Choose a reason for hiding this comment

gotmax23 commented Jul 13, 2023

mariolenz commented Jul 13, 2023

rndmh3ro commented Jul 14, 2023

felixfontein commented Jul 14, 2023

felixfontein Jul 14, 2023

Choose a reason for hiding this comment

felixfontein Jul 14, 2023

Choose a reason for hiding this comment

rndmh3ro commented Jul 17, 2023

felixfontein commented Jul 18, 2023

mariolenz commented Jul 18, 2023

rndmh3ro commented Jul 20, 2023

mariolenz commented Jul 20, 2023

rndmh3ro commented Jul 21, 2023

rndmh3ro commented Jul 21, 2023

felixfontein commented Jul 21, 2023

felixfontein commented Jul 21, 2023

mariolenz commented Jul 23, 2023

felixfontein commented Jul 23, 2023