Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified appliance_networking test #563

Conversation

prabinovRedhat
Copy link
Collaborator

Modified appliance_networking test to run on real vCenter env

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.05%. Comparing base (c93fe26) to head (fac9efa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #563   +/-   ##
=======================================
  Coverage   37.05%   37.05%           
=======================================
  Files         145      145           
  Lines       11395    11395           
  Branches     2261     2261           
=======================================
  Hits         4222     4222           
  Misses       7173     7173           
Flag Coverage Δ
sanity 37.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prabinovRedhat
Copy link
Collaborator Author

cc: @shellymiron @anna-savina

Copy link
Contributor

Copy link
Collaborator

@anna-savina anna-savina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except small suggestion

@prabinovRedhat prabinovRedhat force-pushed the continue_modify_appliance_tests branch from 6831639 to fac9efa Compare December 4, 2024 11:21
Copy link
Contributor

@shellymiron
Copy link
Collaborator

/lgtm

Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/3276e82d8522492f9a7904bf2a05d445

✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 14m 57s
✔️ build-ansible-collection SUCCESS in 7m 27s
✔️ ansible-galaxy-importer SUCCESS in 5m 58s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit e7ea4a9 into ansible-collections:main Dec 4, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants