-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update references to deprecated library item info module #561
update references to deprecated library item info module #561
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #561 +/- ##
=======================================
Coverage 37.05% 37.05%
=======================================
Files 145 145
Lines 11395 11395
Branches 2261 2261
=======================================
Hits 4222 4222
Misses 7173 7173
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Build succeeded. ✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 13m 32s |
Should also be add |
This doesn't seem right to me, the documentation looks confusing. Is there any other way to change it? |
Ill look into it but theres no way to adjust it in this repo |
Im not sure which requirements.yml your referring to, but the integration tests one already has vmware.vmware. And vmware.vmware is not a requirement for using this collection, even though its referenced in the docs, so I dont think it should be added to the galaxy.yml dependencies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Build succeeded (gate pipeline). ✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 14m 27s |
07a9611
into
ansible-collections:main
SUMMARY
This change updates references to the deprecated content_library_item_info module. It changes the collection from vmware.vmware_rest to vmware.vmware
I updated the tests and examples. I don't think we should update the module parameter descriptions since those are autogenerated. The links in those descriptions go the the main module page, which mentions that module is deprecated and users should use the new version anyway.
ISSUE TYPE
COMPONENT NAME
content_library_item_info