Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update references to deprecated library item info module #561

Conversation

mikemorency
Copy link
Collaborator

SUMMARY

This change updates references to the deprecated content_library_item_info module. It changes the collection from vmware.vmware_rest to vmware.vmware

I updated the tests and examples. I don't think we should update the module parameter descriptions since those are autogenerated. The links in those descriptions go the the main module page, which mentions that module is deprecated and users should use the new version anyway.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

content_library_item_info

@mikemorency mikemorency changed the title update references to depreacted library item info module update references to deprecated library item info module Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.05%. Comparing base (e569c6b) to head (48571f0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #561   +/-   ##
=======================================
  Coverage   37.05%   37.05%           
=======================================
  Files         145      145           
  Lines       11395    11395           
  Branches     2261     2261           
=======================================
  Hits         4222     4222           
  Misses       7173     7173           
Flag Coverage Δ
sanity 37.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@anna-savina
Copy link
Collaborator

Should also be add requirements.yml with vmware.vmware collection?

@anna-savina
Copy link
Collaborator

anna-savina commented Dec 3, 2024

I don't think we should update the module parameter descriptions since those are autogenerated.

This doesn't seem right to me, the documentation looks confusing. Is there any other way to change it?

@mikemorency
Copy link
Collaborator Author

I don't think we should update the module parameter descriptions since those are autogenerated.

This doesn't seem right to me, the documentation looks confusing. Is there any other way to change it?

Ill look into it but theres no way to adjust it in this repo

@mikemorency
Copy link
Collaborator Author

Should also be add requirements.yml with vmware.vmware collection?

Im not sure which requirements.yml your referring to, but the integration tests one already has vmware.vmware. And vmware.vmware is not a requirement for using this collection, even though its referenced in the docs, so I dont think it should be added to the galaxy.yml dependencies.

Copy link
Collaborator

@anna-savina anna-savina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/bc89403bac444b9ca97b5eb9dbf0d5d5

✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 14m 27s
✔️ build-ansible-collection SUCCESS in 7m 50s
✔️ ansible-galaxy-importer SUCCESS in 4m 25s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 07a9611 into ansible-collections:main Dec 15, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants