-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/lookup plugin regression #552
Bugfix/lookup plugin regression #552
Conversation
db9bdd5
to
97a10b4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #552 +/- ##
=======================================
Coverage 37.04% 37.05%
=======================================
Files 145 145
Lines 11388 11395 +7
Branches 2258 2261 +3
=======================================
+ Hits 4219 4222 +3
- Misses 7169 7173 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Build succeeded. ✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 15m 10s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Build succeeded (gate pipeline). ✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 14m 15s |
1efb395
into
ansible-collections:main
SUMMARY
After refactoring one of the methods, lookup results broke. This was partially due to missing async keywords and improper dictionary cloning when creating a temporary set of search filters
This issue also made it clear that the filters do not need (nor should be) reset each time we search for an object. The method that performed that reset has been removed
ISSUE TYPE
COMPONENT NAME
all lookup plugins