Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/lookup plugin regression #552

Conversation

mikemorency
Copy link
Collaborator

@mikemorency mikemorency commented Nov 20, 2024

SUMMARY

After refactoring one of the methods, lookup results broke. This was partially due to missing async keywords and improper dictionary cloning when creating a temporary set of search filters

This issue also made it clear that the filters do not need (nor should be) reset each time we search for an object. The method that performed that reset has been removed

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

all lookup plugins

@mikemorency mikemorency force-pushed the bugfix/lookup-plugin-regression branch from db9bdd5 to 97a10b4 Compare November 20, 2024 14:48
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 37.05%. Comparing base (81953ff) to head (d34300b).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
plugins/plugin_utils/lookup.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #552   +/-   ##
=======================================
  Coverage   37.04%   37.05%           
=======================================
  Files         145      145           
  Lines       11388    11395    +7     
  Branches     2258     2261    +3     
=======================================
+ Hits         4219     4222    +3     
- Misses       7169     7173    +4     
Flag Coverage Δ
sanity 37.05% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

Copy link
Collaborator

@anna-savina anna-savina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/8be958fd5fd543d58ba8efbcdd0f7d01

✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 14m 15s
✔️ build-ansible-collection SUCCESS in 7m 37s
✔️ ansible-galaxy-importer SUCCESS in 3m 08s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 1efb395 into ansible-collections:main Nov 21, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants