Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance appliance_health target to run on vCenter env #545

Conversation

prabinovRedhat
Copy link
Collaborator

@prabinovRedhat prabinovRedhat commented Nov 4, 2024

https://issues.redhat.com/browse/ACA-1884

  • This PR updates the appliance_health target to support execution in a vCenter environment.

Since the appliance and appliance-multi-hosts targets seems to be disabled in Zuul (at this time), the intention for these target changes is to eventually replace the original targets. Once this transition is complete, they will be removed from Zuul, and only the eco-vcenter-ci will be supported. Please share your thoughts and opinions on this approach.

@prabinovRedhat prabinovRedhat changed the title Enhance appliance_health target Enhance appliance_health target to run on vCenter env Nov 4, 2024
@prabinovRedhat prabinovRedhat force-pushed the modify_test_appliance_health branch from 6748917 to 4224494 Compare November 4, 2024 15:29
@prabinovRedhat prabinovRedhat changed the title Enhance appliance_health target to run on vCenter env WIP - Enhance appliance_health target to run on vCenter env Nov 4, 2024
Copy link
Contributor

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.04%. Comparing base (81953ff) to head (3ddb8b7).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #545   +/-   ##
=======================================
  Coverage   37.04%   37.04%           
=======================================
  Files         145      145           
  Lines       11388    11388           
  Branches     2258     2258           
=======================================
  Hits         4219     4219           
  Misses       7169     7169           
Flag Coverage Δ
sanity 37.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prabinovRedhat prabinovRedhat changed the title WIP - Enhance appliance_health target to run on vCenter env Enhance appliance_health target to run on vCenter env Nov 5, 2024
@prabinovRedhat
Copy link
Collaborator Author

Please take a look when you have time, @shellymiron @anna-savina @mikemorency

Copy link
Contributor

@prabinovRedhat prabinovRedhat force-pushed the modify_test_appliance_health branch 3 times, most recently from 498b7ab to c7dfc17 Compare November 6, 2024 11:15
Copy link
Contributor

@prabinovRedhat prabinovRedhat force-pushed the modify_test_appliance_health branch 3 times, most recently from 359f3ec to 43bf9e8 Compare November 6, 2024 12:40
Copy link
Contributor

@mikemorency mikemorency self-requested a review November 6, 2024 13:23
@prabinovRedhat prabinovRedhat force-pushed the modify_test_appliance_health branch from 43bf9e8 to 7c5df25 Compare November 6, 2024 13:27
Copy link
Contributor

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/ansible-collections/vmware.vmware_rest for 545,7c5df258009c68bb661670f796b8b931b9d83751

@prabinovRedhat prabinovRedhat force-pushed the modify_test_appliance_health branch from 7c5df25 to bdf3106 Compare November 6, 2024 13:29
@prabinovRedhat prabinovRedhat force-pushed the modify_test_appliance_health branch from bdf3106 to 3ddb8b7 Compare November 6, 2024 13:31
Copy link
Collaborator

@anna-savina anna-savina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shellymiron
Copy link
Collaborator

LGTM

Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/5209aa1852e2448299e7c1d4c2f3b974

✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 13m 03s
✔️ build-ansible-collection SUCCESS in 7m 51s
✔️ ansible-galaxy-importer SUCCESS in 6m 02s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 16768a8 into ansible-collections:main Nov 6, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants