Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing typos in module documentation #541

Conversation

mikemorency
Copy link
Collaborator

SUMMARY

Fixes some grammatical errors in the vcenter_rest_log_file parameter description.
Also fixes some typos and spacing issues in the customization module documentation

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME
  • vcenter_vm_guest_customization
  • vcenter_rest_log_file param

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/d56c3ae83b36461fa61b042a1905f01e

⚠️ ansible-test-cloud-integration-vmware-rest SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection NODE_FAILURE Node request 200-0007622405 failed in 0s
⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.04%. Comparing base (91ce77b) to head (5719008).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #541   +/-   ##
=======================================
  Coverage   37.04%   37.04%           
=======================================
  Files         145      145           
  Lines       11388    11388           
  Branches     2258     2258           
=======================================
  Hits         4219     4219           
  Misses       7169     7169           
Flag Coverage Δ
sanity 37.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikemorency
Copy link
Collaborator Author

recheck

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/8c3eb6cf784e4529ab03528fb1ee224a

⚠️ ansible-test-cloud-integration-vmware-rest SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection NODE_FAILURE Node request 200-0007622438 failed in 0s
⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection

@anna-savina
Copy link
Collaborator

@mikemorency
Copy link
Collaborator Author

@anna-savina Im unable to fix that line. It comes directly from the VMware REST API documentation, and will reverted whenever the modules are generated

@mikemorency
Copy link
Collaborator Author

recheck

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/9f8d2b6bd49b4d9a87cd1c22dd7b836a

⚠️ ansible-test-cloud-integration-vmware-rest SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection NODE_FAILURE Node request 200-0007623713 failed in 0s
⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection

Copy link
Collaborator

@anna-savina anna-savina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikemorency
Copy link
Collaborator Author

recheck

Copy link
Contributor

Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/cbd51cdde2a34e479522b21cd703d550

✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 14m 16s
✔️ build-ansible-collection SUCCESS in 7m 13s
✔️ ansible-galaxy-importer SUCCESS in 5m 14s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 3958614 into ansible-collections:main Oct 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants