-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Build Ansible Docs workflow #518
Conversation
Build succeeded. ✔️ build-ansible-collection SUCCESS in 8m 01s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for following up. I completely overlooked this
feel free to merge when ready
Build succeeded (gate pipeline). ✔️ build-ansible-collection SUCCESS in 7m 56s |
Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry. |
This fixed the original error, but now there's a new one. @mikemorency @alinabuzachis This workflow is quite new, it looks like you've introduced it only 3 weeks ago. Do we really need (or at least want) this? In that case, it would be great if you could make it succeed. If not, should we simply drop it? |
I got the action to pass, but the github pages link just leads to a 404. |
I have no idea 🤷 You've introduced this in #505 and @alinabuzachis approved. Where did you get this workflow from, and why did you add it? For community.vmware I've dropped the docs some time ago and simply rely on it being part of the Ansible Community Package and the documentation showing up on docs.ansible.com. Which is also the case for vmware.vmware_rest. So if neither you nor @alinabuzachis can give a good reason to have this workflow, I repeat my suggestion to drop it ;-) |
SUMMARY This workflow fails the CI, while at the same time I don't understand why it's even there. I think we should remove it. ISSUE TYPE Bugfix Pull Request COMPONENT NAME .github/workflows/docs-push.yml ADDITIONAL INFORMATION ansible-collections#518 ansible-collections#511 ansible-collections#505 Reviewed-by: mikemorency
SUMMARY
Trying to fix the
Build Ansible Docs
CI workflow which fails ATM.ISSUE TYPE
COMPONENT NAME
.github/workflows/docs-push.yml
ADDITIONAL INFORMATION
This and the following comment.