Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vmware.vmware for docs CI #513

Merged

Conversation

mariolenz
Copy link
Collaborator

SUMMARY

Now that some modules reference vmware.vmware we see some problems in the CI checking the documentation. I'm not sure if this will fix it, it's just a try.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

.github/workflows/docs-pr.yml

ADDITIONAL INFORMATION

#511

@mariolenz mariolenz force-pushed the add-vmware.vmware-for-docs-ci branch from e74bf12 to 0c9988f Compare August 12, 2024 17:30
@mikemorency
Copy link
Collaborator

@mariolenz the modules dont have the seealso section on your branch, which is where the error is occuring. That section was added when i re-generated them

Copy link
Contributor

@mariolenz mariolenz mentioned this pull request Aug 12, 2024
@mariolenz
Copy link
Collaborator Author

the modules dont have the seealso section on your branch, which is where the error is occuring. That section was added when i re-generated them

I know. But I think even if I add a seealso to a module, the CI would use the current CI workflow instead of the changed one from this PR. So I think we have to merge this first and then test again.

Let's give it a try! I mean you can want to drop this completely (#512) and we can always do it. So I don't see any harm in merging this and testing again.

@mikemorency
Copy link
Collaborator

mikemorency commented Aug 12, 2024

It's using the ci workflow from your branch. See here
https://github.com/ansible-collections/vmware.vmware_rest/actions/runs/10356563102/job/28666661588?pr=513
It installs the extra collection you specified

Edit: the relevant step is called "install extra collections", I thought my link expanded that step but it doesnt

Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/0c49945dbfaa4e1aa8d59a112e231b3e

✔️ build-ansible-collection SUCCESS in 7m 51s
✔️ ansible-galaxy-importer SUCCESS in 6m 21s

Copy link
Contributor

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

@mariolenz mariolenz merged commit 7915e6d into ansible-collections:main Aug 12, 2024
12 checks passed
@mariolenz mariolenz deleted the add-vmware.vmware-for-docs-ci branch August 12, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants