Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless tests/sanity/ignore-2.*.txt files lower than 2.14 #458

Conversation

alinabuzachis
Copy link
Collaborator

SUMMARY

Remove useless tests/sanity/ignore-2.*.txt files lower than 2.14

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Copy link
Contributor

Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

But at the end of the day, creating these files should be removed from ansible.content_builder ;-)

Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/e10edafec17f43c280aee53f0b60a1c4

✔️ build-ansible-collection SUCCESS in 10m 40s
✔️ tox-cloud-refresh-examples-vmware SUCCESS in 11m 02s
✔️ ansible-galaxy-importer SUCCESS in 4m 29s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit bebe4bf into ansible-collections:main Dec 12, 2023
9 checks passed
@alinabuzachis
Copy link
Collaborator Author

LGTM

But at the end of the day, creating these files should be removed from ansible.content_builder ;-)

Will prep a PR for doing that!

Copy link

patchback bot commented Mar 13, 2024

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/bebe4bf93fe5b0a4253a2cc67353cfc4712b6f29/pr-458

Backported as #488

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 13, 2024
Remove useless tests/sanity/ignore-2.*.txt files lower than 2.14

SUMMARY

Remove useless tests/sanity/ignore-2.*.txt files lower than 2.14

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mike Graves <mgraves@redhat.com>
Reviewed-by: Mario Lenz <m@riolenz.de>
(cherry picked from commit bebe4bf)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Mar 13, 2024
… (#488)

[PR #458/bebe4bf9 backport][stable-3] Remove useless tests/sanity/ignore-2.*.txt files lower than 2.14

This is a backport of PR #458 as merged into main (bebe4bf).
SUMMARY

Remove useless tests/sanity/ignore-2.*.txt files lower than 2.14

ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
Reviewed-by: Ondra Machacek <machacek.ondra@gmail.com>
mikemorency pushed a commit to mikemorency/vmware.vmware_rest that referenced this pull request Aug 16, 2024
…ible-collections#458)

Remove useless tests/sanity/ignore-2.*.txt files lower than 2.14

SUMMARY

Remove useless tests/sanity/ignore-2.*.txt files lower than 2.14

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mike Graves <mgraves@redhat.com>
Reviewed-by: Mario Lenz <m@riolenz.de>
(cherry picked from commit bebe4bf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants