Fix GHA sanity tests

[mariolenz]

Fix GHA sanity tests.

Follow-up to #431

edit:

I know those files are generated and shouldn't be touched manually, but I'd like to see the CI succeeding. Most of the stuff were unused imports. In the long run, I think we need a fix for this: ansible-community/ansible.content_builder#67

However, there were also two issues that we should have a closer look at:

ERROR: Found 2 validate-modules issue(s) which need to be resolved:
ERROR: plugins/modules/vcenter_vm_hardware_adapter_sata.py:0:0: doc-default-does-not-match-spec: Argument 'bus' in argument_spec defines default as (0) but documentation defines default as (None)
ERROR: plugins/modules/vcenter_vm_hardware_adapter_scsi.py:0:0: doc-default-does-not-match-spec: Argument 'bus' in argument_spec defines default as (0) but documentation defines default as (None)

Might be a bug in the code generator.

edit2:

I'll remove the 2.16 sanity tests again because:

Running sanity test "import" on Python 3.12
Run command with data: importer.py
Run command with data: importer.py
ERROR: Found 132 import issue(s) on python 3.12 which need to be resolved:
ERROR: plugins/modules/appliance_access_consolecli.py:256:0: traceback: DeprecationWarning: There is no current event loop
.
.
.

[codecov]

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/7f9813d0421949268679472a1c019557

✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 18m 49s
✔️ build-ansible-collection SUCCESS in 10m 12s
✔️ ansible-tox-linters SUCCESS in 15m 04s
❌ ansible-test-sanity-docker-devel FAILURE in 17m 24s (non-voting)
❌ ansible-test-sanity-docker-milestone FAILURE in 13m 45s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 15m 43s
✔️ ansible-test-sanity-docker-stable-2.10 SUCCESS in 14m 27s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 13m 28s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 15m 44s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 19m 15s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 11m 19s
✔️ tox-cloud-refresh-examples-vmware SUCCESS in 10m 57s
✔️ ansible-galaxy-importer SUCCESS in 3m 44s

[softwarefactory-project-zuul]

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/84ae561d068e4d58be36156b309ddd07

✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 13m 19s
✔️ build-ansible-collection SUCCESS in 10m 08s
✔️ ansible-tox-linters SUCCESS in 11m 57s
❌ ansible-test-sanity-docker-devel FAILURE in 9m 07s (non-voting)
❌ ansible-test-sanity-docker-milestone FAILURE in 10m 25s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 17m 05s
❌ ansible-test-sanity-docker-stable-2.10 FAILURE in 8m 54s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 15m 53s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 11s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 19s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 15m 30s
✔️ tox-cloud-refresh-examples-vmware SUCCESS in 12m 01s
✔️ ansible-galaxy-importer SUCCESS in 3m 42s

[softwarefactory-project-zuul]

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

[mariolenz]

Thanks for reviewing @alinabuzachis!

[webknjaz]

@mariolenz you should probably skip running the changelog workflow on push events and only run in on pull_request: https://github.com/ansible-collections/vmware.vmware_rest/commit/d372262c12773521c8a1d5108c39e70e6f3e199a/checks. Also, you could wire it into the main test workflow (via reusable workflows) and connect it to the check job, so it could be used in unified gating.

[mariolenz]

@mariolenz you should probably skip running the changelog workflow on push events and only run in on pull_request

@webknjaz Good idea, but how? Like this: #433?

Also, you could wire it into the main test workflow (via reusable workflows) and connect it to the check job, so it could be used in unified gating.

I'm not very good at GHA, I mostly copy&paste stuff together from somewhere else and hope that it will work 🤷

But feel free to open a PR if you want to have it like this :-)