-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: Accept release candidate versions for compatibility checks #745
helm: Accept release candidate versions for compatibility checks #745
Conversation
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 8m 36s |
Hi @gileri, could you please create a changelog fragment for your PR as mentioned in collection development guide? |
Build failed.
|
recheck |
Build failed.
|
recheck |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 7m 52s |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 46s |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 7m 55s |
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 7m 53s |
6a04f42
into
ansible-collections:main
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #753 🤖 @patchback |
SUMMARY If the helm CLI version includes -rc.1 for example, the version checks fails due to an incomplete regex. The error can be triggered if you use helm v3.15.0-rc.1 for example, and apply a helm chart with wait: true ISSUE TYPE Bugfix Pull Request COMPONENT NAME helm helm_pull ADDITIONAL INFORMATION Reviewed-by: Yuriy Novostavskiy Reviewed-by: Eric G. Reviewed-by: Mike Graves <mgraves@redhat.com> (cherry picked from commit 6a04f42)
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #754 🤖 @patchback |
SUMMARY If the helm CLI version includes -rc.1 for example, the version checks fails due to an incomplete regex. The error can be triggered if you use helm v3.15.0-rc.1 for example, and apply a helm chart with wait: true ISSUE TYPE Bugfix Pull Request COMPONENT NAME helm helm_pull ADDITIONAL INFORMATION Reviewed-by: Yuriy Novostavskiy Reviewed-by: Eric G. Reviewed-by: Mike Graves <mgraves@redhat.com> (cherry picked from commit 6a04f42)
… (#753) This is a backport of PR #745 as merged into main (6a04f42). SUMMARY If the helm CLI version includes -rc.1 for example, the version checks fails due to an incomplete regex. The error can be triggered if you use helm v3.15.0-rc.1 for example, and apply a helm chart with wait: true ISSUE TYPE Bugfix Pull Request COMPONENT NAME helm helm_pull ADDITIONAL INFORMATION Reviewed-by: Mike Graves <mgraves@redhat.com>
… (#754) This is a backport of PR #745 as merged into main (6a04f42). SUMMARY If the helm CLI version includes -rc.1 for example, the version checks fails due to an incomplete regex. The error can be triggered if you use helm v3.15.0-rc.1 for example, and apply a helm chart with wait: true ISSUE TYPE Bugfix Pull Request COMPONENT NAME helm helm_pull ADDITIONAL INFORMATION Reviewed-by: Mike Graves <mgraves@redhat.com>
SUMMARY Version 3.3.0 of ansible-collection kubernetes.core came with several improvements and bugfixes ISSUE TYPE New release pull request Changelog Minor Changes k8s_drain - Improve error message for pod disruption budget when draining a node (#797). Bugfixes helm - Helm version checks did not support RC versions. They now accept any version tags. (#745). helm_pull - Apply no_log=True to pass_credentials to silence false positive warning.. (#796). k8s_drain - Fix k8s_drain does not wait for single pod (#769). k8s_drain - Fix k8s_drain runs into a timeout when evicting a pod which is part of a stateful set (#792). kubeconfig option should not appear in module invocation log (#782). kustomize - kustomize plugin fails with deprecation warnings (#639). waiter - Fix waiting for daemonset when desired number of pods is 0. (#756). ADDITIONAL INFORMATION Collection kubernets.core version 3.3.0 is compatible with ansible-core>=2.14.0 Reviewed-by: Alina Buzachis Reviewed-by: Yuriy Novostavskiy Reviewed-by: Mike Graves <mgraves@redhat.com>
SUMMARY This release came with new module helm_registry_auth, and improvements to the error messages in the k8s_drain module, new parameter insecure_registry for helm_template module and several bug fixes. ISSUE TYPE New release pull request Changelog Minor Changes Bump version of ansible-lint to minimum 24.7.0 (#765). Parameter insecure_registry added to helm_template as equivalent of insecure-skip-tls-verify (#805). connection/kubectl.py - Added an example of using the kubectl connection plugin to the documentation (#741). k8s_drain - Improve error message for pod disruption budget when draining a node (#797). Bugfixes helm - Helm version checks did not support RC versions. They now accept any version tags. (#745). helm_pull - Apply no_log=True to pass_credentials to silence false positive warning.. (#796). k8s_drain - Fix k8s_drain does not wait for single pod (#769). k8s_drain - Fix k8s_drain runs into a timeout when evicting a pod which is part of a stateful set (#792). kubeconfig option should not appear in module invocation log (#782). kustomize - kustomize plugin fails with deprecation warnings (#639). waiter - Fix waiting for daemonset when desired number of pods is 0. (#756). New Modules helm_registry_auth - Helm registry authentication module ADDITIONAL INFORMATION Collection kubernets.core version 3.1.0 is compatible with ansible-core>=2.15.0 Reviewed-by: Mike Graves <mgraves@redhat.com>
SUMMARY This release came with new module helm_registry_auth, and improvements to the error messages in the k8s_drain module, new parameter insecure_registry for helm_template module and several bug fixes. ISSUE TYPE New release pull request Changelog Minor Changes Bump version of ansible-lint to minimum 24.7.0 (ansible-collections#765). Parameter insecure_registry added to helm_template as equivalent of insecure-skip-tls-verify (ansible-collections#805). connection/kubectl.py - Added an example of using the kubectl connection plugin to the documentation (ansible-collections#741). k8s_drain - Improve error message for pod disruption budget when draining a node (ansible-collections#797). Bugfixes helm - Helm version checks did not support RC versions. They now accept any version tags. (ansible-collections#745). helm_pull - Apply no_log=True to pass_credentials to silence false positive warning.. (ansible-collections#796). k8s_drain - Fix k8s_drain does not wait for single pod (ansible-collections#769). k8s_drain - Fix k8s_drain runs into a timeout when evicting a pod which is part of a stateful set (ansible-collections#792). kubeconfig option should not appear in module invocation log (ansible-collections#782). kustomize - kustomize plugin fails with deprecation warnings (ansible-collections#639). waiter - Fix waiting for daemonset when desired number of pods is 0. (ansible-collections#756). New Modules helm_registry_auth - Helm registry authentication module ADDITIONAL INFORMATION Collection kubernets.core version 3.1.0 is compatible with ansible-core>=2.15.0 Reviewed-by: Mike Graves <mgraves@redhat.com>
SUMMARY
If the helm CLI version includes
-rc.1
for example, the version checks fails due to an incomplete regex.The error can be triggered if you use helm v3.15.0-rc.1 for example, and apply a helm chart with
wait: true
ISSUE TYPE
COMPONENT NAME
helm
helm_pull
ADDITIONAL INFORMATION