Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: Accept release candidate versions for compatibility checks #745

Merged

Conversation

gileri
Copy link
Contributor

@gileri gileri commented Jun 10, 2024

SUMMARY

If the helm CLI version includes -rc.1 for example, the version checks fails due to an incomplete regex.
The error can be triggered if you use helm v3.15.0-rc.1 for example, and apply a helm chart with wait: true

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

helm
helm_pull

ADDITIONAL INFORMATION

Copy link

@yurnov
Copy link
Contributor

yurnov commented Jun 11, 2024

Hi @gileri,

could you please create a changelog fragment for your PR as mentioned in collection development guide?

Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/a273f312314c49219c33029934876084

⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection NODE_FAILURE Node request 200-0007259914 failed in 0s

@gravesm
Copy link
Member

gravesm commented Jun 11, 2024

recheck

Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/f7d7990d2bf74a558cb96b2d5c01c195

⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection NODE_FAILURE Node request 200-0007259959 failed in 0s

@gravesm
Copy link
Member

gravesm commented Jun 11, 2024

recheck

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/a74c5133860b4837af98ff1df055126f

✔️ ansible-galaxy-importer SUCCESS in 7m 52s
✔️ build-ansible-collection SUCCESS in 7m 40s

Copy link

@gravesm gravesm closed this Jun 17, 2024
@gravesm gravesm reopened this Jun 17, 2024
Copy link

Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/4f3f4f578a2a447fb9757a67579cdfe0

✔️ ansible-galaxy-importer SUCCESS in 7m 53s
✔️ build-ansible-collection SUCCESS in 6m 51s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 6a04f42 into ansible-collections:main Jun 17, 2024
75 of 77 checks passed
Copy link

patchback bot commented Jun 17, 2024

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/6a04f42d0bb85756af5c5946907bbd80bdb1666f/pr-745

Backported as #753

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 17, 2024
SUMMARY

If the helm CLI version includes -rc.1 for example, the version checks fails due to an incomplete regex.
The error can be triggered if you use helm v3.15.0-rc.1 for example, and apply a helm chart with wait: true
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
helm
helm_pull
ADDITIONAL INFORMATION

Reviewed-by: Yuriy Novostavskiy
Reviewed-by: Eric G.
Reviewed-by: Mike Graves <mgraves@redhat.com>
(cherry picked from commit 6a04f42)
Copy link

patchback bot commented Jun 17, 2024

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/6a04f42d0bb85756af5c5946907bbd80bdb1666f/pr-745

Backported as #754

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 17, 2024
SUMMARY

If the helm CLI version includes -rc.1 for example, the version checks fails due to an incomplete regex.
The error can be triggered if you use helm v3.15.0-rc.1 for example, and apply a helm chart with wait: true
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
helm
helm_pull
ADDITIONAL INFORMATION

Reviewed-by: Yuriy Novostavskiy
Reviewed-by: Eric G.
Reviewed-by: Mike Graves <mgraves@redhat.com>
(cherry picked from commit 6a04f42)
@gileri gileri deleted the helm-version-rc branch June 17, 2024 19:10
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jun 18, 2024
… (#753)

This is a backport of PR #745 as merged into main (6a04f42).
SUMMARY

If the helm CLI version includes -rc.1 for example, the version checks fails due to an incomplete regex.
The error can be triggered if you use helm v3.15.0-rc.1 for example, and apply a helm chart with wait: true 
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME
helm
helm_pull
ADDITIONAL INFORMATION

Reviewed-by: Mike Graves <mgraves@redhat.com>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jun 18, 2024
… (#754)

This is a backport of PR #745 as merged into main (6a04f42).
SUMMARY

If the helm CLI version includes -rc.1 for example, the version checks fails due to an incomplete regex.
The error can be triggered if you use helm v3.15.0-rc.1 for example, and apply a helm chart with wait: true 
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME
helm
helm_pull
ADDITIONAL INFORMATION

Reviewed-by: Mike Graves <mgraves@redhat.com>
@yurnov yurnov mentioned this pull request Jan 20, 2025
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jan 20, 2025
SUMMARY
Version 3.3.0 of ansible-collection kubernetes.core came with several improvements and bugfixes
ISSUE TYPE

New release pull request

Changelog
Minor Changes

k8s_drain - Improve error message for pod disruption budget when draining a node (#797).

Bugfixes

helm - Helm version checks did not support RC versions. They now accept any version tags. (#745).
helm_pull - Apply no_log=True to pass_credentials to silence false positive warning.. (#796).
k8s_drain - Fix k8s_drain does not wait for single pod (#769).
k8s_drain - Fix k8s_drain runs into a timeout when evicting a pod which is part of a stateful set  (#792).
kubeconfig option should not appear in module invocation log (#782).
kustomize - kustomize plugin fails with deprecation warnings (#639).
waiter - Fix waiting for daemonset when desired number of pods is 0. (#756).

ADDITIONAL INFORMATION
Collection kubernets.core version 3.3.0 is compatible with ansible-core>=2.14.0

Reviewed-by: Alina Buzachis
Reviewed-by: Yuriy Novostavskiy
Reviewed-by: Mike Graves <mgraves@redhat.com>
This was referenced Jan 20, 2025
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jan 20, 2025
SUMMARY
This release came with new module helm_registry_auth, and improvements to the error messages in the k8s_drain module, new parameter insecure_registry for helm_template module and several bug fixes.
ISSUE TYPE

New release pull request

Changelog
Minor Changes

Bump version of ansible-lint to minimum 24.7.0 (#765).
Parameter insecure_registry added to helm_template as equivalent of insecure-skip-tls-verify (#805).
connection/kubectl.py - Added an example of using the kubectl connection plugin to the documentation (#741).
k8s_drain - Improve error message for pod disruption budget when draining a node (#797).

Bugfixes

helm - Helm version checks did not support RC versions. They now accept any version tags. (#745).
helm_pull - Apply no_log=True to pass_credentials to silence false positive warning.. (#796).
k8s_drain - Fix k8s_drain does not wait for single pod (#769).
k8s_drain - Fix k8s_drain runs into a timeout when evicting a pod which is part of a stateful set  (#792).
kubeconfig option should not appear in module invocation log (#782).
kustomize - kustomize plugin fails with deprecation warnings (#639).
waiter - Fix waiting for daemonset when desired number of pods is 0. (#756).

New Modules

helm_registry_auth - Helm registry authentication module

ADDITIONAL INFORMATION
Collection kubernets.core version 3.1.0 is compatible with ansible-core>=2.15.0

Reviewed-by: Mike Graves <mgraves@redhat.com>
yurnov added a commit to yurnov/kubernetes.core that referenced this pull request Jan 20, 2025
SUMMARY
This release came with new module helm_registry_auth, and improvements to the error messages in the k8s_drain module, new parameter insecure_registry for helm_template module and several bug fixes.
ISSUE TYPE

New release pull request

Changelog
Minor Changes

Bump version of ansible-lint to minimum 24.7.0 (ansible-collections#765).
Parameter insecure_registry added to helm_template as equivalent of insecure-skip-tls-verify (ansible-collections#805).
connection/kubectl.py - Added an example of using the kubectl connection plugin to the documentation (ansible-collections#741).
k8s_drain - Improve error message for pod disruption budget when draining a node (ansible-collections#797).

Bugfixes

helm - Helm version checks did not support RC versions. They now accept any version tags. (ansible-collections#745).
helm_pull - Apply no_log=True to pass_credentials to silence false positive warning.. (ansible-collections#796).
k8s_drain - Fix k8s_drain does not wait for single pod (ansible-collections#769).
k8s_drain - Fix k8s_drain runs into a timeout when evicting a pod which is part of a stateful set  (ansible-collections#792).
kubeconfig option should not appear in module invocation log (ansible-collections#782).
kustomize - kustomize plugin fails with deprecation warnings (ansible-collections#639).
waiter - Fix waiting for daemonset when desired number of pods is 0. (ansible-collections#756).

New Modules

helm_registry_auth - Helm registry authentication module

ADDITIONAL INFORMATION
Collection kubernets.core version 3.1.0 is compatible with ansible-core>=2.15.0

Reviewed-by: Mike Graves <mgraves@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants