Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s_log - fix module traceback when resource not found #493

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Jul 22, 2022

Depends-on: #495

SUMMARY

closes #479

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

k8s_log

@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ build-ansible-collection SUCCESS in 3m 03s
ansible-test-sanity-docker-devel RETRY_LIMIT in 6m 33s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 9m 14s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 10m 44s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 05s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 19s
✔️ ansible-test-units-kubernetes-core-python38 SUCCESS in 6m 54s
✔️ ansible-test-splitter SUCCESS in 2m 32s
✔️ integration-kubernetes.core-devel-1 SUCCESS in 7m 27s (non-voting)
⚠️ integration-kubernetes.core-devel-2 SKIPPED (non-voting)
⚠️ integration-kubernetes.core-devel-3 SKIPPED (non-voting)
✔️ integration-kubernetes.core-milestone-1 SUCCESS in 7m 33s
⚠️ integration-kubernetes.core-milestone-2 SKIPPED
⚠️ integration-kubernetes.core-milestone-3 SKIPPED
✔️ integration-kubernetes.core-2.9-1 SUCCESS in 6m 55s
⚠️ integration-kubernetes.core-2.9-2 SKIPPED
⚠️ integration-kubernetes.core-2.9-3 SKIPPED
✔️ integration-kubernetes.core-2.10-1 SUCCESS in 6m 40s
⚠️ integration-kubernetes.core-2.10-2 SKIPPED
⚠️ integration-kubernetes.core-2.10-3 SKIPPED
✔️ integration-kubernetes.core-with-turbo-1 SUCCESS in 6m 33s
⚠️ integration-kubernetes.core-with-turbo-2 SKIPPED
⚠️ integration-kubernetes.core-with-turbo-3 SKIPPED
✔️ ansible-tox-linters SUCCESS in 4m 47s
✔️ ansible-galaxy-importer SUCCESS in 4m 15s

plugins/modules/k8s_log.py Outdated Show resolved Hide resolved
@abikouo abikouo force-pushed the k8s_log_traceback branch from 5db8b9c to d9e3fab Compare July 26, 2022 10:03
@abikouo abikouo requested review from gravesm and Akasurde July 26, 2022 10:04
@softwarefactory-project-zuul
Copy link

Build failed.

✔️ build-ansible-collection SUCCESS in 3m 13s
ansible-test-sanity-docker-devel FAILURE in 7m 52s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 9m 32s (non-voting)
ansible-test-sanity-docker-stable-2.9 FAILURE in 12m 07s
ansible-test-sanity-docker-stable-2.11 FAILURE in 12m 13s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 57s
✔️ ansible-test-units-kubernetes-core-python38 SUCCESS in 6m 21s
✔️ ansible-test-splitter SUCCESS in 2m 42s
✔️ integration-kubernetes.core-devel-1 SUCCESS in 7m 05s (non-voting)
⚠️ integration-kubernetes.core-devel-2 SKIPPED (non-voting)
⚠️ integration-kubernetes.core-devel-3 SKIPPED (non-voting)
✔️ integration-kubernetes.core-milestone-1 SUCCESS in 8m 29s
⚠️ integration-kubernetes.core-milestone-2 SKIPPED
⚠️ integration-kubernetes.core-milestone-3 SKIPPED
✔️ integration-kubernetes.core-2.9-1 SUCCESS in 8m 58s
⚠️ integration-kubernetes.core-2.9-2 SKIPPED
⚠️ integration-kubernetes.core-2.9-3 SKIPPED
✔️ integration-kubernetes.core-2.10-1 SUCCESS in 7m 11s
⚠️ integration-kubernetes.core-2.10-2 SKIPPED
⚠️ integration-kubernetes.core-2.10-3 SKIPPED
✔️ integration-kubernetes.core-with-turbo-1 SUCCESS in 7m 06s
⚠️ integration-kubernetes.core-with-turbo-2 SKIPPED
⚠️ integration-kubernetes.core-with-turbo-3 SKIPPED
✔️ ansible-tox-linters SUCCESS in 5m 14s
✔️ ansible-galaxy-importer SUCCESS in 4m 19s

@gravesm
Copy link
Member

gravesm commented Jul 27, 2022

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ build-ansible-collection SUCCESS in 3m 02s
ansible-test-sanity-docker-devel FAILURE in 10m 18s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 8m 32s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 15m 36s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 58s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 45s
✔️ ansible-test-units-kubernetes-core-python38 SUCCESS in 5m 10s
✔️ ansible-test-splitter SUCCESS in 2m 32s
✔️ integration-kubernetes.core-devel-1 SUCCESS in 7m 46s (non-voting)
⚠️ integration-kubernetes.core-devel-2 SKIPPED (non-voting)
⚠️ integration-kubernetes.core-devel-3 SKIPPED (non-voting)
✔️ integration-kubernetes.core-milestone-1 SUCCESS in 7m 01s
⚠️ integration-kubernetes.core-milestone-2 SKIPPED
⚠️ integration-kubernetes.core-milestone-3 SKIPPED
✔️ integration-kubernetes.core-2.9-1 SUCCESS in 8m 13s
⚠️ integration-kubernetes.core-2.9-2 SKIPPED
⚠️ integration-kubernetes.core-2.9-3 SKIPPED
✔️ integration-kubernetes.core-2.10-1 SUCCESS in 7m 52s
⚠️ integration-kubernetes.core-2.10-2 SKIPPED
⚠️ integration-kubernetes.core-2.10-3 SKIPPED
✔️ integration-kubernetes.core-with-turbo-1 SUCCESS in 8m 02s
⚠️ integration-kubernetes.core-with-turbo-2 SKIPPED
⚠️ integration-kubernetes.core-with-turbo-3 SKIPPED
✔️ ansible-tox-linters SUCCESS in 4m 57s
✔️ ansible-galaxy-importer SUCCESS in 4m 06s

@abikouo abikouo removed the request for review from Akasurde July 28, 2022 09:19
@softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

1 similar comment
@softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).

✔️ build-ansible-collection SUCCESS in 3m 01s
ansible-test-sanity-docker-devel FAILURE in 7m 34s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 7m 28s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 10m 39s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 50s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 13s
✔️ ansible-test-units-kubernetes-core-python38 SUCCESS in 5m 49s
✔️ ansible-test-splitter SUCCESS in 2m 29s
✔️ integration-kubernetes.core-devel-1 SUCCESS in 6m 10s (non-voting)
⚠️ integration-kubernetes.core-devel-2 SKIPPED (non-voting)
⚠️ integration-kubernetes.core-devel-3 SKIPPED (non-voting)
✔️ integration-kubernetes.core-milestone-1 SUCCESS in 6m 52s
⚠️ integration-kubernetes.core-milestone-2 SKIPPED
⚠️ integration-kubernetes.core-milestone-3 SKIPPED
✔️ integration-kubernetes.core-2.9-1 SUCCESS in 7m 22s
⚠️ integration-kubernetes.core-2.9-2 SKIPPED
⚠️ integration-kubernetes.core-2.9-3 SKIPPED
✔️ integration-kubernetes.core-2.10-1 SUCCESS in 6m 18s
⚠️ integration-kubernetes.core-2.10-2 SKIPPED
⚠️ integration-kubernetes.core-2.10-3 SKIPPED
✔️ integration-kubernetes.core-with-turbo-1 SUCCESS in 7m 09s
⚠️ integration-kubernetes.core-with-turbo-2 SKIPPED
⚠️ integration-kubernetes.core-with-turbo-3 SKIPPED
✔️ ansible-tox-linters SUCCESS in 4m 59s
✔️ ansible-galaxy-importer SUCCESS in 5m 18s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 7f7008f into ansible-collections:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

k8s_log module traceback when no resource found
2 participants