Continue waiting when an exception is raised #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gravesm
reviewed
Mar 16, 2022
done |
|
I am testing your PR on my side, but unfortunately the Error was not eliminated. This is the result on my testing environment (sorry not RHEL, but macOS). I tested by just rebooting the target OCP4 node. I suppose this block caused the above error. kubernetes.core/plugins/module_utils/common.py Lines 424 to 435 in df9968e |
Indeed this piece of code was also part of the fix but forgot to commit it.
@sugitk thanks for the feedback |
|
@abikouo Thank you very much for your quick review, I will try your branch tomorrow. (now it's 11pm here..) |
|
@abikouo Good morning. I have tested with your branch (ex_wait), it worked as expected! |
Thanks for the feedback!! |
|
recheck |
|
@gravesm Do you have time to review this PR to merge? The customer is waiting for the fix.. |
|
@Akasurde could you please add your review here ? Thanks |
Akasurde
reviewed
Mar 23, 2022
Akasurde
reviewed
Mar 23, 2022
Akasurde
reviewed
Mar 23, 2022
gravesm
approved these changes
Mar 23, 2022
|
recheck |
Akasurde
approved these changes
Mar 23, 2022
gravesm
pushed a commit
to gravesm/kubernetes.core
that referenced
this pull request
Apr 28, 2022
Continue waiting when an exception is raised SUMMARY When an exception is raised and the wait_timeout is not reached, we should continue waiting as this may occurs due to temporary issue on cluster Fixes ansible-collections#407 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mike Graves <mgraves@redhat.com> Reviewed-by: Abhijeet Kasurde <None> (cherry picked from commit f418353)
gravesm
pushed a commit
to gravesm/kubernetes.core
that referenced
this pull request
May 2, 2022
Continue waiting when an exception is raised SUMMARY When an exception is raised and the wait_timeout is not reached, we should continue waiting as this may occurs due to temporary issue on cluster Fixes ansible-collections#407 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mike Graves <mgraves@redhat.com> Reviewed-by: Abhijeet Kasurde <None> (cherry picked from commit f418353)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 2, 2022
) [backport/2.3] continue waiting when an exception is raised (#408) Depends-On: #446 Continue waiting when an exception is raised SUMMARY When an exception is raised and the wait_timeout is not reached, we should continue waiting as this may occurs due to temporary issue on cluster Fixes #407 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mike Graves mgraves@redhat.com Reviewed-by: Abhijeet Kasurde (cherry picked from commit f418353)
gravesm
added a commit
to gravesm/community.okd
that referenced
this pull request
May 4, 2022
Previous to ansible-collections/kubernetes.core#408 an attempt to list resources for which the user was not authorized resulted in an unhandled exception. The task now does not fail, but instead reports the error message.
gravesm
added a commit
to openshift/community.okd
that referenced
this pull request
May 5, 2022
* Fix integration tests for k8s 2.3 Previous to ansible-collections/kubernetes.core#408 an attempt to list resources for which the user was not authorized resulted in an unhandled exception. The task now does not fail, but instead reports the error message. * try to fix sanity * Fix tests * fix tests * fix tests * Revert change to downstream build
gravesm
added a commit
to gravesm/kubernetes.core
that referenced
this pull request
Jun 8, 2022
Port changes from commit f418353 to the refactored code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When an exception is raised and the wait_timeout is not reached, we should continue waiting as this may occurs due to temporary issue on cluster
Fixes #407
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION