Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing attributes to BGP neighbors peer group #81

Merged
merged 19 commits into from
May 19, 2022
Merged

Added missing attributes to BGP neighbors peer group #81

merged 19 commits into from
May 19, 2022

Conversation

stalabi1
Copy link
Collaborator

@stalabi1 stalabi1 commented May 11, 2022

SUMMARY

I added the following OC attributes to the bgp_neighbors module for peer groups:

bfd: check-control-plane-failure, enabled, bfd-profile
disable-ebgp-connected-route-check
dont-negotiate-capability
ebgp-multihop : enabled, multihop-ttl
enforce-first-as
enforce-multihop
local address
local-as
local-as-no-prepend
local-as-replace-as
override-capability
passive-mode
pg-description
shutdown-message
solo-peer
strict-capability-match
timers: connect-retry
ttl-security-hops

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

sonic_bgp_neighbors

ADDITIONAL INFORMATION

show_running_configuration_bgp_pg_output.txt

@stalabi1 stalabi1 requested a review from kerry-meyer May 11, 2022 23:07
@kerry-meyer
Copy link
Collaborator

Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the current proposed changes and test results look good.

Approved.

@kerry-meyer kerry-meyer merged commit 7ebd3bf into ansible-collections:main May 19, 2022
@stalabi1 stalabi1 deleted the bgp_nbr branch August 3, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants