-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing attributes to BGP neighbors peer group #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est case deletion issue
Testing Verification: regression-2022-05-11-13-07-45.pdf |
kerry-meyer
reviewed
May 16, 2022
kerry-meyer
reviewed
May 16, 2022
kerry-meyer
approved these changes
May 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the current proposed changes and test results look good.
Approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
I added the following OC attributes to the bgp_neighbors module for peer groups:
bfd: check-control-plane-failure, enabled, bfd-profile
disable-ebgp-connected-route-check
dont-negotiate-capability
ebgp-multihop : enabled, multihop-ttl
enforce-first-as
enforce-multihop
local address
local-as
local-as-no-prepend
local-as-replace-as
override-capability
passive-mode
pg-description
shutdown-message
solo-peer
strict-capability-match
timers: connect-retry
ttl-security-hops
ISSUE TYPE
COMPONENT NAME
sonic_bgp_neighbors
ADDITIONAL INFORMATION
show_running_configuration_bgp_pg_output.txt