Add primary-ip configuration support for the sonic_vxlans module #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change set provides the modifications needed to configure the "primary-ip" address attribute for vxlan vtep interfaces, including the ability to modify the existing value of the attribute, and to delete the attribute. It also adds regression test cases for adding, modifying, and deleting primary-ip address configuration.
jeff-yin
approved these changes
Feb 4, 2022
stalabi1
approved these changes
Feb 4, 2022
Don't omit from switch configuration requests that attempt "out of sequence" attempts to add/delete primary-ip and source-ip address configuration with vxlan mapping present. This generates silent failures along with missing configuration. Instead, allow the "out of sequence" invalid configuration to be passed to the switch to generate failure messages so users can make the needed changes in their playbooks.
stalabi1
approved these changes
Feb 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This change set provides the modifications needed to configure the
"primary-ip" address attribute for vxlan vtep interfaces, including
the ability to modify the existing value of the attribute, and to
delete the attribute.
It also adds regression test cases for adding, modifying, and
deleting primary-ip address configuration.
ISSUE TYPE
COMPONENT NAME
dellemc.enterprise_sonic (sonic_vxlans)
ADDITIONAL INFORMATION
These changes provide the functionality for configuration and testing of "primary-ip"
address configuration for the sonic_vxlans module. For full functionality, the
co-requisite BGP configuration capability is also required.
Dell Enterprise SONiC Ansible regression results for sonic_vxlans after adding
these changes:
regression-primary_ip_pass_2022-02-01-21-44-13.pdf
Regression re-run after making PR changes to eliminate silent failure on "out of sequence"
PIP or source-ip address deletion:
regression-primary_ip_pass_2022-02-04-17-04-58.pdf
Verification of CLI "show" output after using Ansible to add and modify PIP configuration:
vxlan_pip_cli_ut_verification.txt