-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OC Compliance Changes #53
Merged
kerry-meyer
merged 21 commits into
ansible-collections:main
from
stalabi1:oc_compliance
Nov 23, 2021
Merged
OC Compliance Changes #53
kerry-meyer
merged 21 commits into
ansible-collections:main
from
stalabi1:oc_compliance
Nov 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerry-meyer
reviewed
Nov 23, 2021
kerry-meyer
reviewed
Nov 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the pre-existing pipeline problems.
This change set looks good.
I will approve it now.
kerry-meyer
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Updated ansible code to be OC compliant and resolved sanity check errors
ISSUE TYPE
COMPONENT NAME
aaa
bgp
bgp_af
bgp_as_paths
bgp_neighbors
bgp_neighbors_af
l2_interfaces
l3_interfaces
radius_server
tacacs_server
REGRESSION TEST RESULTS
oc_compliance_regression_results_2021_11_22.pdf
l2-regression-2021-11-23-09-33-29.pdf
(The results posted above were obtained using image the following SONiC switch image: dell_sonic_share build #322)