Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OC Compliance Changes #53

Merged
merged 21 commits into from
Nov 23, 2021
Merged

OC Compliance Changes #53

merged 21 commits into from
Nov 23, 2021

Conversation

stalabi1
Copy link
Collaborator

@stalabi1 stalabi1 commented Nov 22, 2021

SUMMARY

Updated ansible code to be OC compliant and resolved sanity check errors

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

aaa
bgp
bgp_af
bgp_as_paths
bgp_neighbors
bgp_neighbors_af
l2_interfaces
l3_interfaces
radius_server
tacacs_server

REGRESSION TEST RESULTS

oc_compliance_regression_results_2021_11_22.pdf
l2-regression-2021-11-23-09-33-29.pdf

(The results posted above were obtained using image the following SONiC switch image: dell_sonic_share build #322)

Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the pre-existing pipeline problems.

This change set looks good.

I will approve it now.

@kerry-meyer kerry-meyer merged commit d02a3bd into ansible-collections:main Nov 23, 2021
@stalabi1 stalabi1 deleted the oc_compliance branch May 26, 2022 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants