Update mysql.yml #823
Merged
Update mysql.yml #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BGmot
reviewed
Oct 14, 2022
There was a problem hiding this comment.
Won't we fail with "undefined variable" here https://github.com/ansible-collections/community.zabbix/blob/main/roles/zabbix_server/tasks/mysql.yml#L130 ?
|
It proceded to run the rest of the role when I made this change in my test environment. But I'll leave it up to you to confirm. |
|
I don't know why bunch of tests got cancelled, waiting for somebody who knows GitHub workflows better to take a look. |
D3DeFi
approved these changes
Oct 15, 2022
|
I have honestly no idea why the checks were cancelled.., but I've triggered their re-run. Otherwise LGTM and can merge after tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #804
ISSUE TYPE
COMPONENT NAME
zabbix_server role
mysql task
ADDITIONAL INFORMATION