-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for Zabbix 6.0 #683
Fixes for Zabbix 6.0 #683
Conversation
Codecov Report
@@ Coverage Diff @@
## main #683 +/- ##
==========================================
+ Coverage 70.39% 75.85% +5.45%
==========================================
Files 27 27
Lines 3581 3641 +60
Branches 935 988 +53
==========================================
+ Hits 2521 2762 +241
+ Misses 772 571 -201
- Partials 288 308 +20
Continue to review full report at Codecov.
|
…e must not be provided.
…d passwd must not be provided in API call (Zabbix 6.0)
…uld be equal to ['B', 'A'] (Zabbix 6.0).
…are dicts and lists instead of just strings).
Looks good @BGmot 👍 As long as the |
Removed [WIP]. Thanks for your help! |
I would like to read through this first tomorrow so I better understand all of the changes and then we can merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What an amazing patch this is! Really good job @BGmot , thank you!
Can you please check my comments and help me understand some of the logic I pin-pointed? I think this is almost ready to be merged. And there are even tests! <3
Can you please also drop short changelog fragments to changelogs/fragments/683-zbx60.yml? https://docs.ansible.com/ansible/latest/community/development_process.html#creating-a-changelog-fragment
tests/integration/targets/test_zabbix_user/tasks/for_zabbix_54_higher.yml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I am ok with merging :)
Or will you be pushing removal of i2
?
I will be pushing removal of i2 and updating CHANGELOG but it's going to be later, stupid work distracts me from what I love doing -( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! :) Once again, thank you very much for this amazing patch!
Anytime. Thanks for your your guidance. |
SUMMARY
Many modules currently fail with Zabbix 6.0.
This PR makes all modules correctly work with 6.0 with backward compatibility to previous Zabbix versions.
ISSUE TYPE
COMPONENT NAME
plugins/modules/zabbix_action.py
plugins/modules/zabbix_maintenance.py
plugins/modules/zabbix_mediatype.py
plugins/modules/zabbix_proxy.py
plugins/modules/zabbix_service.py