Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows agent(2) role refactoring #453

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

errcmd
Copy link
Contributor

@errcmd errcmd commented Sep 7, 2021

SUMMARY

Added zabbix agent 2 support
Added migration from 1 to 2 and vice versa.
Fixed agent 2 log path in j2 template
Fixed issue with windows firewall on windows server 2016\2019

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

Windows.yml

ADDITIONAL INFORMATION

Added agent2 support (upgrade and downgrade covered)
Change upgrade rule, now it checks exe version and in mismatch => reinstall
Fixed agent2 log path in jinja template
Fixed win firewall issue on 2016\2019 (win_service not working anymore, due to missing permissions on admins\users)


@errcmd errcmd marked this pull request as ready for review September 7, 2021 23:02
@dj-wasabi
Copy link
Contributor

Hi @errcmd , is it ready to be merged? (I almost pushed the merge button untill I noticed a new commit.) So to be safe, I ask first. :)

@errcmd
Copy link
Contributor Author

errcmd commented Sep 8, 2021

@dj-wasabi my bad, it's ready to go now.

@dj-wasabi dj-wasabi merged commit b74db9a into ansible-collections:main Sep 8, 2021
@dj-wasabi
Copy link
Contributor

No worries! Thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants