Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[+] Added zabbix_server_startlldprocessors var for ZBX Server #361

Merged
merged 2 commits into from
Apr 16, 2021

Conversation

cardinalit
Copy link
Contributor

SUMMARY

Added variable StartLLDProcessors. Allows to change default value of ZBX Server using ansible-playbook.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • zabbix_server
ADDITIONAL INFORMATION

If you want to change default variable of ZBX Server — StartLLDProcessors (default: 2) using current Ansible Collection, you can't do it, because the template does not have it, nor does the default value for this variable.

I added setting to roles/zabbix_server/templates/zabbix_server.conf.j2 and added variable zabbix_server_startlldprocessors to roles/zabbix_server/defaults/main.yml.

Have a nice day!

@dj-wasabi
Copy link
Contributor

Hi,

Thank you for making time to create a PR. Can I ask you to do the following:
Can you make the piece configurable so it won't be added in older versions of Zabbix? Something with {% if zabbix_version is version('4.2', '>=') %} ? Otherwise people with Zabbix 3.x or 4.0 have issues deploying their zabbix servers.

Thanks!

@cardinalit
Copy link
Contributor Author

Hi,

Of course!

@dj-wasabi dj-wasabi merged commit 7c8bbe6 into ansible-collections:main Apr 16, 2021
@dj-wasabi
Copy link
Contributor

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants