Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort host interfaces before mapping them #309

Merged
merged 2 commits into from
Jan 11, 2021
Merged

Sort host interfaces before mapping them #309

merged 2 commits into from
Jan 11, 2021

Conversation

D3DeFi
Copy link
Contributor

@D3DeFi D3DeFi commented Jan 7, 2021 •
edited
Loading

SUMMARY

Should fix #253 and #244 when there is more than one interface

COMPONENT NAME

plugins/modules/zabbix_host.py

@codecov
Copy link

codecov bot commented Jan 7, 2021 •
edited
Loading

Codecov Report

Merging #309 (5c599e0) into main (03a2c58) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #309   +/-   ##
=======================================
  Coverage   77.19%   77.20%           
=======================================
  Files          19       19           
  Lines        2684     2685    +1     
  Branches      688      689    +1     
=======================================
+ Hits         2072     2073    +1     
  Misses        409      409           
  Partials      203      203
Impacted Files Coverage Δ
...ns/community/zabbix/plugins/modules/zabbix_host.py 83.58% <0.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9eb60a...5c599e0. Read the comment docs.

@D3DeFi D3DeFi mentioned this pull request Jan 7, 2021
Closed
@D3DeFi D3DeFi force-pushed the zabbix-host-interfaces-fix branch from d58c0b2 to 6c5603e Compare January 11, 2021 13:27
@D3DeFi D3DeFi changed the title WIP: debugging host interface Sort host interfaces before mapping them Jan 11, 2021
@D3DeFi D3DeFi requested a review from sky-joker January 11, 2021 13:44
@D3DeFi D3DeFi added the module The issue or pull request is related to Zabbix module label Jan 11, 2021
sky-joker
sky-joker approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@sky-joker sky-joker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you @D3DeFi for this patch!

@sky-joker sky-joker merged commit 51630d7 into ansible-collections:main Jan 11, 2021
@D3DeFi D3DeFi deleted the zabbix-host-interfaces-fix branch January 11, 2021 14:04
@D3DeFi D3DeFi mentioned this pull request Mar 13, 2021
Closed
@smarrk smarrk mentioned this pull request May 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sky-joker sky-joker sky-joker approved these changes

Assignees
No one assigned
Labels
module The issue or pull request is related to Zabbix module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zabbix_host hasn't the idempotence when a host has two interfaces or more
2 participants
@D3DeFi @sky-joker