fix: make statusport really optional

[darkobas2]

Status port is supposed to be configured when zabbix_agent2_statusport is defined. Since its defined in defaults its always defined. Therefore we remove it from default

roles/zabbix_agent/templates/agent.conf.j2

• {{ (zabbix_agent_statusport is defined and zabbix_agent_statusport is not none) | ternary('', '# ') }}StatusPort={{ zabbix_agent_statusport | default('') }}

COMPONENT NAME

agent2

[pyrodie18]

I am pretty sure that there are several variables within the configuration files that are optional, but still have a value in defaults/vars for one reason or another. I hesitate to remove this right now for two reasons. 1. It being there isn't breaking anything (that I'm tracking). 2. Removing it may break a someone's existing deployment which would make this a breaking change that we would only do on a major release (don't expect we'll be doing one of those for a while since we just released 3.0. If this is causing you problems, I would suggest defining in your vars a null value to override it.

Thoughts @BGmot, @masa-orca, @eb4x

[darkobas2]

cool, ill go with null for now

[BGmot]

I am pretty sure that there are several variables within the configuration files that are optional, but still have a value in defaults/vars for one reason or another. I hesitate to remove this right now for two reasons. 1. It being there isn't breaking anything (that I'm tracking). 2. Removing it may break a someone's existing deployment which would make this a breaking change that we would only do on a major release (don't expect we'll be doing one of those for a while since we just released 3.0. If this is causing you problems, I would suggest defining in your vars a null value to override it.

Thoughts @BGmot, @masa-orca, @eb4x

Agree with your statement.

[pyrodie18]

OK, I hear what @evilhamsterman is saying in #1384

[pyrodie18]

forgot to hit the re-open button