-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOPS 3.9.0: use encrypt/decrypt subcommands, use --filename-override option for encryption, use filestatus to check for encrypted files #190
Conversation
…option for encryption.
b5860b3
to
d7ea8fb
Compare
715e099
to
be72218
Compare
be72218
to
5ed7954
Compare
Docs Build 📝Thank you for contribution!✨ This PR has been merged and the docs are now incorporated into |
944b5a9
to
e9b2c3b
Compare
…t be decrypted is unencrypted.
e9b2c3b
to
2475315
Compare
dc8d9cd
to
383cb7f
Compare
This is now ready for review! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a nitpick, looks great to me!
else: | ||
self._warn('Cannot extract SOPS version from: %s' % repr(output)) | ||
else: | ||
self._debug('Cannot detect SOPS version efficiently, likely a version before 3.8.0') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest to remove efficiently
as it suggest that some form of version detection happened, which is not the case.
self._debug('Cannot detect SOPS version efficiently, likely a version before 3.8.0') | |
self._debug('Cannot detect SOPS version, likely a version before 3.8.0') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually efficicently is the whole point here: only 3.8.0 and later allow to disable the network request done when calling sops --version
, which makes sops --version
rather slow (0.3-0.7 seconds vs. 0.01-0.03 seconds runtime for 3.9.0, not sure how slow it is with older versions, since the way the version check worked changed over time).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the clarification! So that cli flag avoids the roundtrip speeding up the command. Let's merge this! 👍
@endorama thanks for reviewing this! |
Motivation
Use new features of SOPS 3.9.0 to improve various things in this collection.
Changes description
encrypt
/decrypt
subcommands with SOPS 3.9.0+.--filename-override
when encrypting with SOPS 3.9.0+. This fixes If.sops.yaml
contains apath_regex
sops_encrypt doesn't work #153.filestatus
command to detect whether a file is SOPS encrypted (vars plugin).