Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query rules 2 #77

Merged
merged 5 commits into from
Sep 28, 2021
Merged

Conversation

markuman
Copy link
Member

SUMMARY

Closes: #71

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

proxysq_query_rules

@markuman markuman mentioned this pull request Sep 24, 2021
@markuman
Copy link
Member Author

@Andersson007 can you checkout and run locally?
works for me against 2.1.1 and 1.4.15. And yeah, changelog is missing.

@Andersson007
Copy link
Contributor

@Andersson007 can you checkout and run locally?

sure:)

works for me against 2.1.1 and 1.4.15. And yeah, changelog is missing.

should we add bugfixes: one?

@Andersson007
Copy link
Contributor

the tests succeeded locally for me

markuman and others added 2 commits September 27, 2021 19:22
…p_test_query_rule.yml

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
@markuman
Copy link
Member Author

@Andersson007 changelog added.
I re-run tests against 2.x.x and 1.4.15 on a fresh vm. LGTM.

Copy link
Contributor

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markuman markuman merged commit 7b7c5eb into ansible-collections:main Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proxysql_mysql_query_rules becomes incompatible with 1.4.x since 1.1.0
2 participants