Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing required lib #50

Merged
merged 9 commits into from
Jul 22, 2021
Merged

Missing required lib #50

merged 9 commits into from
Jul 22, 2021

Conversation

markuman
Copy link
Member

SUMMARY

Rework error handling when required libraries are missing using from ansible.module_utils.basic import missing_required_lib

closes #47

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

Every module is affected in this collection

@markuman markuman changed the title [WIP] Missing required lib Missing required lib Jul 21, 2021
Andersson007
Andersson007 reviewed Jul 22, 2021
View reviewed changes
Copy link
Contributor

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markuman thanks for the PR!

plugins/module_utils/mysql.py Outdated Show resolved Hide resolved
@Andersson007
Copy link
Contributor

Andersson007 commented Jul 22, 2021 •
edited
Loading

We could also add a changelog fragment here with the minor_changes: key https://docs.ansible.com/ansible/latest/community/development_process.html#creating-a-changelog-fragment saying, for example - Refactoring of connector presence checking (https://github.com/ansible-collections/community.proxysql/pull/50). or something

@markuman @Andersson007
Update changelogs/fragments/50-refactor-connectors.yaml
c1ce4c8 
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
@Andersson007 Andersson007 merged commit df5ede0 into ansible-collections:main Jul 22, 2021
@Andersson007
Copy link
Contributor

@markuman thanks for the refactoring!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andersson007 Andersson007 Andersson007 approved these changes

@bmildren bmildren Awaiting requested review from bmildren

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement missing_required_lib and dropping MySQL-python (Python 2.x only) at the same time?
2 participants
@markuman @Andersson007