Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ci: too many blank lines #120

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Conversation

markuman
Copy link
Member

ERROR: Found 1 yamllint issue(s) which need to be resolved:
ERROR: tests/integration/targets/test_proxysql_query_rules_fast_routing/tasks/107-update_destination_hostgroup.yml:62:1: empty-lines: too many blank lines (1 > 0)

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #120 (86b282a) into main (beca67f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #120   +/-   ##
=======================================
  Coverage   75.14%   75.14%           
=======================================
  Files          10       10           
  Lines        1199     1199           
  Branches      193      193           
=======================================
  Hits          901      901           
  Misses        221      221           
  Partials       77       77           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@markuman markuman merged commit 4db0eab into ansible-collections:main Oct 19, 2022
markuman added a commit to markuman/community.proxysql that referenced this pull request Dec 22, 2022
markuman added a commit to markuman/community.proxysql that referenced this pull request Dec 22, 2022
@Andersson007
Copy link
Contributor

@markuman btw we can set up backporting by the bot here (using labels like stable-1 for example), we need to

  1. add a similar file https://github.com/ansible-collections/community.postgresql/blob/main/.github/patchback.yml
  2. install "Patchback" app to the repo (i can)

Just a fyi, if sounds OK, feel free to add the file and let me know when i can install the app

@markuman
Copy link
Member Author

markuman commented Jan 3, 2023

@markuman btw we can set up backporting by the bot here (using labels like stable-1 for example), we need to

1. add a similar file https://github.com/ansible-collections/community.postgresql/blob/main/.github/patchback.yml

2. install "Patchback" app to the repo (i can)

Just a fyi, if sounds OK, feel free to add the file and let me know when i can install the app

@Andersson007 sounds good. but the current backports must be still done manually.

@Andersson007
Copy link
Contributor

Andersson007 commented Jan 3, 2023

@markuman I've just enabled the app, so please:

markuman added a commit that referenced this pull request Jan 3, 2023
#120 (#130)

* Skip checking flagIN value before inserting rules (#108)

* Skip checking flagIN value before inserting rules

* Add changelogs fragments

* Update changelogs/fragments/107-update_destination_hostgroup.yml

* include integration test

* fix typo

* more debug outputs

* more checks

* fix query_data order

* append changelog

Co-authored-by: Markus Bergholz <git@osuv.de>

* too many blank lines (#120)

Co-authored-by: Squirrel <squirrel532@protonmail.com>
@markuman markuman mentioned this pull request Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants