deprecate 'priv' argument in postgresql_user

[hunleyd]

SUMMARY

Deprecate the priv argument of postgresql_user in favor of the postgresql_privs module

fixes #212

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

postgresql_user

[hunleyd]

Unsupported parameters for (ansible.legacy.command) module: warn

that doesn't appear to be my error. is the pipeline ok @Andersson007 ?

[Andersson007]

Unsupported parameters for (ansible.legacy.command) module: warn

that doesn't appear to be my error. is the pipeline ok @Andersson007 ?

@hunleyd Thanks for the PR!
Please take a look at tests/integration/targets/setup_postgresql_db/tasks/main.yml

163   - name: Reinstall internationalization files
164     shell: yum -y reinstall glibc-common || yum -y install glibc-common
165     args:
166       warn: false
167     when: locale_present is failed

I think some args have been deprecated here (or something else happened related to the warn: thing), I would re-write it somehow. I would start with removing args: warn: false.

[Andersson007]

@hunleyd As it's not something directly related, feel free to submit a separate PR. It would be much easier to backport. Once the dedicated PR is merged, we can re-launch the tests here (if no time for that, please let me know).

[hunleyd]

I think some args have been deprecated here (or something else happened related to the warn: thing), I would re-write it somehow. I would start with removing args: warn: false.

According to the docs that arg is still valid though which is why I'm confused.

[Andersson007]

I'm also confused because #228 has passed...

[Andersson007]

Ah, no, it was just skipped

[Andersson007]

@hunleyd it's not valid https://docs.ansible.com/ansible/devel/collections/ansible/builtin/shell_module.html. We should choose devel in the upper left corner in this case

[Andersson007]

One of changelog fragments in ansible/ansible:

  1 removed_features:
  2   - Remove deprecated ``COMMAND_WARNINGS`` configuration option (https://github.com/ansible/ansible/issues/77394)
  3   - command/shell - remove deprecated ``warn`` module param

[hunleyd]

Error when getting collection version metadata for community.general:3.0.2 from default (https://galaxy.ansible.com/api/) (HTTP Code: 429, Message: Too Many Requests Code: Unknown)
guess i'll try again later ;)

[Andersson007]

Error when getting collection version metadata for community.general:3.0.2 from default (https://galaxy.ansible.com/api/) (HTTP Code: 429, Message: Too Many Requests Code: Unknown) guess i'll try again later ;)

yep, we should adjust things to install c.general from git instead (i always forget about it)

[Andersson007]

Could you please take a look at #227 (comment) and #227 (comment) ?