fix connection arguments mysql driver compatability #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e "db" is deprecated/removed
Codecov Report
@@ Coverage Diff @@
## main #551 +/- ##
==========================================
- Coverage 77.12% 74.04% -3.08%
==========================================
Files 28 18 -10
Lines 2365 2254 -111
Branches 557 560 +3
==========================================
- Hits 1824 1669 -155
- Misses 383 413 +30
- Partials 158 172 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Andersson007
approved these changes
May 18, 2023
laurent-indermuehle
pushed a commit
to laurent-indermuehle/community.mysql
that referenced
this pull request
Oct 3, 2023
…ons#551) * only use the "database" connection argument with driver versions where "db" is deprecated/removed * connection arguments: fix KeyError * connection arguments: fix KeyError * connection arguments: use 'passwd' instead of 'password' with older drivers * add changelog fragment * refactoring: use "get_connector_name" in "mysql_connect" --------- Co-authored-by: Felix Hamme <felix.hamme@ionos.com>
laurent-indermuehle
pushed a commit
to laurent-indermuehle/community.mysql
that referenced
this pull request
Oct 3, 2023
…ons#551) * only use the "database" connection argument with driver versions where "db" is deprecated/removed * connection arguments: fix KeyError * connection arguments: fix KeyError * connection arguments: use 'passwd' instead of 'password' with older drivers * add changelog fragment * refactoring: use "get_connector_name" in "mysql_connect" --------- Co-authored-by: Felix Hamme <felix.hamme@ionos.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfix for #546, relates to #116
what arguments are supported in what drivers
dbargument in 1.0.0 (2021), but it will probably still work for some time. I'm not sure since when pymysql supports thedatabaseargument, but at least since 0.7.11, which we test.db. The project was last changed in 2014 so we could discuss if we want to support it. The current issue is about this old driver, see Possible recurrence of issue #151 following latest release of community.mysql? #546 (comment).dbargument in 2.1.0 (2021), like pymysql.The same way,
passwdis deprecated in favor ofpassword.proposed fix
Check the mysql driver version to determine what argument to use. Use
dbandpasswduntil it's deprecated, thendatabaseandpassword.