mysql_role: don't add members to a role when creating the role and "detach_members: true" is set #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etach_members: true" is set, add integration test
Codecov Report
@@ Coverage Diff @@
## main #367 +/- ##
==========================================
+ Coverage 78.23% 78.25% +0.01%
==========================================
Files 27 27
Lines 2270 2272 +2
Branches 551 552 +1
==========================================
+ Hits 1776 1778 +2
Misses 335 335
Partials 159 159
Continue to review full report at Codecov.
|
|
@betanummeric thanks for the fix! Could you please:
|
Andersson007
approved these changes
May 25, 2022
There was a problem hiding this comment.
@betanummeric LGTM thanks! Let's make the changelog view consistent, could you please change it as suggested? After that I'll merge the PR
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
Andersson007
approved these changes
May 25, 2022
|
@betanummeric thanks for the contribution! |
|
Backported manually #372 |
This was referenced Jun 2, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUGFIX: fixes #366 (the "adding unwanted members" part)
SUMMARY
In the mysql_role module, if the argument
detach_membersis true, the role should be revoked from the users specified in themembersargument (if necessary). This PR fixes this behavior for when the role does not exist and is created (avoid granting the role to the users).