Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI matrix update #226

Merged
merged 7 commits into from
Oct 12, 2021
Merged

CI matrix update #226

merged 7 commits into from
Oct 12, 2021

Conversation

Andersson007
Copy link
Collaborator

@Andersson007 Andersson007 commented Oct 6, 2021 •
edited
Loading

SUMMARY

Fixes #154
Fixes #162

CI matrix update

  • Add testing against stable-2.12
  • Add testing against devel
  • Add Python 3.8
  • Fix related failings

@codecov
Copy link

codecov bot commented Oct 6, 2021 •
edited
Loading

Codecov Report

Merging #226 (2ff5c1a) into main (4f205ef) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #226   +/-   ##
=======================================
  Coverage   77.60%   77.60%           
=======================================
  Files          24       24           
  Lines        2170     2170           
  Branches      510      510           
=======================================
  Hits         1684     1684           
  Misses        319      319           
  Partials      167      167

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f205ef...2ff5c1a. Read the comment docs.

@Andersson007
Copy link
Collaborator Author

@Jorge-Rodriguez @unnecessary-username (thank you for exclusion statements in Jorge's PR) could you please take a look?

They are green but I'm not 100% sure I kept the initial logic.

@Andersson007 Andersson007 mentioned this pull request Oct 6, 2021
Closed
@Jorge-Rodriguez
Copy link
Contributor

I'll have a look, hold on for my feedback if you're not in too much of a hurry

@Andersson007
Copy link
Collaborator Author

I'll have a look, hold on for my feedback if you're not in too much of a hurry

sure, will be waiting then:)

unnecessary-username
unnecessary-username approved these changes Oct 9, 2021
View reviewed changes
Copy link
Contributor

@unnecessary-username unnecessary-username left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I could come up with, I think it works as expected.
Thanks for the contribution.

Jorge-Rodriguez
Jorge-Rodriguez approved these changes Oct 10, 2021
View reviewed changes
Copy link
Contributor

@Jorge-Rodriguez Jorge-Rodriguez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the new conditionals. Thank you @unnecessary-username @Andersson007

@Andersson007 Andersson007 merged commit fc984b2 into ansible-collections:main Oct 12, 2021
@Andersson007
Copy link
Collaborator Author

@Jorge-Rodriguez @unnecessary-username thanks for reviewing!

This was referenced Oct 12, 2021
Merged
Closed
Andersson007 added a commit to Andersson007/community.mysql that referenced this pull request Oct 19, 2021
@Andersson007
CI matrix update (ansible-collections#226)
5e9e33f 
* CI matrix update

* Fix test_mysql_user

* Fix CI

* Fix CI

* Fix CI

* Fix CI

* Fix CI

(cherry picked from commit fc984b2)
@Andersson007 Andersson007 mentioned this pull request Oct 19, 2021
Merged
Andersson007 added a commit that referenced this pull request Oct 19, 2021
@Andersson007
[stable-2] Backport stable 2 5 (#235)
55a8ecd 
* Copy ignore-2.12.txt to ignore-2.13.txt (#225)

(cherry picked from commit 4f205ef)

* CI matrix update (#226)

* CI matrix update

* Fix test_mysql_user

* Fix CI

* Fix CI

* Fix CI

* Fix CI

* Fix CI

(cherry picked from commit fc984b2)

* integration tests: remove superfluous debug task (#228)

* integration tests: remove superfluous debug task

* Turn off integration tests against devel

(cherry picked from commit f47d463)

* mysql_user: fix broken compatibility for priviledge aliases (#233)

* mysql_user: fix broken compatibility for priviledge aliases

* add changelog fragment

* fix changelog fragment

* Improve formatting

(cherry picked from commit bb3e9fd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unnecessary-username unnecessary-username unnecessary-username approved these changes

@Jorge-Rodriguez Jorge-Rodriguez Jorge-Rodriguez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable and fix integration tests against devel
3 participants
@Andersson007 @Jorge-Rodriguez @unnecessary-username