Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql_replication: add deprecation warning about future replacement of Is_Slave and Is_Master return values, add alternatives #147

Merged
merged 2 commits into from
Apr 16, 2021
Merged

mysql_replication: add deprecation warning about future replacement of Is_Slave and Is_Master return values, add alternatives #147

merged 2 commits into from
Apr 16, 2021

Conversation

Andersson007
Copy link
Collaborator

SUMMARY

mysql_replication:

  1. add deprecation warnings about future replacement of Is_Slave and Is_Master return values with Is_Primary and Is_Replica
  2. add the alternative return values

@Andersson007
mysql_replication: add deprecation warning about future replacement o…
48149c5 
…f Is_Slave and Is_Master return values, add alternatives
@codecov
Copy link

codecov bot commented Apr 15, 2021 •
edited
Loading

Codecov Report

Merging #147 (9dbb705) into main (1790664) will increase coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
+ Coverage   77.13%   77.18%   +0.05%     
==========================================
  Files          20       20              
  Lines        1784     1788       +4     
  Branches      436      436              
==========================================
+ Hits         1376     1380       +4     
  Misses        265      265              
  Partials      143      143
Impacted Files Coverage Δ
plugins/modules/mysql_replication.py 67.27% <66.66%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1790664...9dbb705. Read the comment docs.

@Andersson007 Andersson007 mentioned this pull request Apr 15, 2021
Closed
@Andersson007
Copy link
Collaborator Author

сс @Jorge-Rodriguez @bmalynovytch

@Andersson007
Copy link
Collaborator Author

FYI currently both Is_Slave and Is_Replica (same for Is_Master and Is_Primary) work.

@Andersson007 Andersson007 merged commit 853db5a into ansible-collections:main Apr 16, 2021
@Andersson007
Copy link
Collaborator Author

@bmalynovytch @Jorge-Rodriguez thanks for reviewing!

Andersson007 added a commit to Andersson007/community.mysql that referenced this pull request Apr 16, 2021
@Andersson007
mysql_replication: add deprecation warning about future replacement o…
144cdde 
…f Is_Slave and Is_Master return values, add alternatives (ansible-collections#147)

* mysql_replication: add deprecation warning about future replacement of Is_Slave and Is_Master return values, add alternatives

* Add changelog fragment

(cherry picked from commit 853db5a)
@Andersson007 Andersson007 mentioned this pull request Apr 16, 2021
Merged
Andersson007 added a commit that referenced this pull request Apr 16, 2021
@Andersson007
mysql_replication: add deprecation warning about future replacement o…
da7e73e 
…f Is_Slave and Is_Master return values, add alternatives (#147) (#149)

* mysql_replication: add deprecation warning about future replacement of Is_Slave and Is_Master return values, add alternatives

* Add changelog fragment

(cherry picked from commit 853db5a)
@Andersson007 Andersson007 mentioned this pull request Nov 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmalynovytch bmalynovytch bmalynovytch approved these changes

@Jorge-Rodriguez Jorge-Rodriguez Jorge-Rodriguez approved these changes

Assignees
No one assigned
Labels
needs_backport_to_stable-2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Andersson007 @Jorge-Rodriguez @bmalynovytch