Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Helm module should use K8S_AUTH_KUBECONFIG when kubeconfig_path isn't specified #140

Closed
joao-fidalgo opened this issue Jun 25, 2020 · 3 comments · Fixed by #141
Closed

Helm module should use K8S_AUTH_KUBECONFIG when kubeconfig_path isn't specified #140

joao-fidalgo opened this issue Jun 25, 2020 · 3 comments · Fixed by #141
Labels
topic/helm Issues relating to helm plugins type/enhancement New feature or request

Comments

@joao-fidalgo
Copy link

SUMMARY

Helm module should use K8S_AUTH_KUBECONFIG when kubeconfig_path isn't specified

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

helm

ADDITIONAL INFORMATION

This change would normalize behaviour between modules.

- hosts: localhost
  gather_facts: false
  connection: local

  collections:
    - community.kubernetes

  environment:
    K8S_AUTH_KUBECONFIG: "/tmp/kubeconfig.yml"

  tasks:
    - name: install rancher using helm
       helm:
        chart_ref: rancher-stable/rancher
        name: rancher
        namespace: cattle-system
@Akasurde
Copy link
Member

Make sense to me. Working on it.

Akasurde added a commit to Akasurde/community.kubernetes that referenced this issue Jun 25, 2020
@Akasurde
helm: Add support for K8S_AUTH_CONTEXT and K8S_AUTH_KUBECONFIG env
39cd3a8 
helm and helm_info modules can now use K8S_AUTH_KUBECONFIG and K8S_AUTH_KUBECONFIG
from environment variable if not specified in task.

Fixes: ansible-collections#140

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde mentioned this issue Jun 25, 2020
Merged
@Akasurde
Copy link
Member

@joao-fidalgo Could you please check if PR #141 works for you? Thanks

@joao-fidalgo
Copy link
Author

@Akasurde LGTM

@Akasurde Akasurde added the type/enhancement New feature or request label Jun 26, 2020
@tima tima added the topic/helm Issues relating to helm plugins label Jul 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/helm Issues relating to helm plugins type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

helm: Add support for K8S_AUTH_CONTEXT, K8S_AUTH_KUBECONFIG env Akasurde/community.kubernetes
3 participants
@tima @Akasurde @joao-fidalgo