Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xml: make module work with lxml 5.1.1 #8169

Merged
merged 1 commit into from
Mar 30, 2024
Merged

xml: make module work with lxml 5.1.1 #8169

merged 1 commit into from
Mar 30, 2024

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

lxml 5.1.1 includes lxml/lxml@eba7934, which breaks the xml module since it assumes that etree._ElementStringResult exists.

On platforms that install lxml via pip, like macOS and RHEL 9, this was breaking the nightly tests (https://dev.azure.com/ansible/community.general/_build/results?buildId=107937&view=results).

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

xml

@felixfontein felixfontein added backport-6 backport-8 Automatically create a backport for the stable-8 branch labels Mar 30, 2024
@ansibullbot
Copy link
Collaborator

cc @cmprescott @dagwieers @sm4rk0 @tbielawa
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module plugins plugin (any type) labels Mar 30, 2024
@felixfontein
Copy link
Collaborator Author

I'm going to merge this to unbreak CI. If someone has comments for this, I'll address them in follow-up PRs.

@felixfontein felixfontein merged commit b444e87 into ansible-collections:main Mar 30, 2024
133 checks passed
@patchback Patchback
Copy link

patchback bot commented Mar 30, 2024 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/b444e8739c4a445311709420b47026a9ebe76ac2/pr-8169

Backported as #8170

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein deleted the lxml branch March 30, 2024 21:32
patchback bot pushed a commit that referenced this pull request Mar 30, 2024
@felixfontein @patchback
xml: make module work with lxml 5.1.1 (#8169)
41a7607 
Make module work with lxml 5.1.1.

(cherry picked from commit b444e87)
@patchback patchback bot mentioned this pull request Mar 30, 2024
Merged
@patchback Patchback
Copy link

patchback bot commented Mar 30, 2024 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/b444e8739c4a445311709420b47026a9ebe76ac2/pr-8169

Backported as #8171

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 30, 2024
@felixfontein @patchback
xml: make module work with lxml 5.1.1 (#8169)
093740c 
Make module work with lxml 5.1.1.

(cherry picked from commit b444e87)
@patchback patchback bot mentioned this pull request Mar 30, 2024
Merged
@patchback Patchback
Copy link

patchback bot commented Mar 30, 2024 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/b444e8739c4a445311709420b47026a9ebe76ac2/pr-8169

Backported as #8172

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 30, 2024
@felixfontein @patchback
xml: make module work with lxml 5.1.1 (#8169)
ee718a5 
Make module work with lxml 5.1.1.

(cherry picked from commit b444e87)
@patchback patchback bot mentioned this pull request Mar 30, 2024
Merged
felixfontein added a commit that referenced this pull request Mar 30, 2024
@patchback @felixfontein
[PR #8169/b444e873 backport][stable-6] xml: make module work with lxm…
34fd2c0 
…l 5.1.1 (#8170)

xml: make module work with lxml 5.1.1 (#8169)

Make module work with lxml 5.1.1.

(cherry picked from commit b444e87)

Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein added a commit that referenced this pull request Mar 30, 2024
@patchback @felixfontein
[PR #8169/b444e873 backport][stable-7] xml: make module work with lxm…
68eb07a 
…l 5.1.1 (#8171)

xml: make module work with lxml 5.1.1 (#8169)

Make module work with lxml 5.1.1.

(cherry picked from commit b444e87)

Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein added a commit that referenced this pull request Mar 30, 2024
@patchback @felixfontein
[PR #8169/b444e873 backport][stable-8] xml: make module work with lxm…
49fb3d7 
…l 5.1.1 (#8172)

xml: make module work with lxml 5.1.1 (#8169)

Make module work with lxml 5.1.1.

(cherry picked from commit b444e87)

Co-authored-by: Felix Fontein <felix@fontein.de>
@felixfontein felixfontein mentioned this pull request May 30, 2024
Closed
1 task
@felixfontein felixfontein mentioned this pull request Jan 2, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-8 Automatically create a backport for the stable-8 branch bug This issue/PR relates to a bug module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixfontein @ansibullbot