[gitlab] Fix gitlab constants calls #7467

Wihrt · 2023-11-03T13:01:59Z

docs(gitlab_user.py): Specify the version constraint for python-gitlab module

SUMMARY

Fix gitlab constants call from python-gitlab library

#7466

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

gitlab_user
gitlab_protected_branch
gitlab_group_members
gitlab_project_members

ADDITIONAL INFORMATION

ansibullbot · 2023-11-03T13:05:44Z

cc @LennertMertens @Lunik @Shaps @lgatellier @marwatk @metanovii @nejch @scodeman @sh0shin @stgrace @suukit @waheedi @zanssa
click here for bot help

nejch · 2023-11-03T13:20:09Z

plugins/modules/gitlab_user.py

@@ -28,7 +28,7 @@
  - Stef Graces (@stgrace)
 requirements:
  - python >= 2.7
-  - python-gitlab python module
+  - python-gitlab python module < 4.0.0


The constants have been defined in gitlab.const since forever, see 1.0.0 in 2017:
https://github.com/python-gitlab/python-gitlab/blob/1.0.0/gitlab/const.py

I think it'd be better to simply import them from there rather than place artificial constraints. WDYT?

The quick fix was to update the docs
The better fix is, for sure, to update the code properly.

I have checked all the gitlab module to make the same kind of modification.

Great, thanks !

Would you mind also fixing gitlab_protected_branch module, which also uses constants directly from gitlab package ?

Missed it, but fixed it :)

lgatellier · 2023-11-03T15:21:23Z

Hi @Wihrt,

Thanks a lot for this contribution !

Could you add a YML changelog fragment into changelogs/fragments directory ?

For an example, see https://github.com/ansible-collections/community.general/blob/stable-7/changelogs/fragments/3787-pass-composer-working-dir.yml

!component +plugins/modules/gitlab_user.py
!component +plugins/modules/gitlab_group_members.py
!component +plugins/modules/gitlab_project_members.py
!component +plugins/modules/gitlab_protected_branch.py

Wihrt · 2023-11-03T15:30:57Z

@lgatellier
I have added the changelog fragment.
I hope it complies with the standards :)

changelogs/fragments/7467-fix-gitlab-constants-calls.yml

plugins/modules/gitlab_protected_branch.py

lgatellier · 2023-11-03T18:20:29Z

Seems good to me, LGTM !

patchback · 2023-11-03T23:41:23Z

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/a366318ac683303d05e14d4a7cbac9c7e2fe3077/pr-7467

Backported as #7473

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

fix: Fix gitlab constants calls Co-authored-by: Arnaud Hatzenbuhler <arnaud.hatzenbuhler@conserto.pro> (cherry picked from commit a366318)

patchback · 2023-11-03T23:41:33Z

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/a366318ac683303d05e14d4a7cbac9c7e2fe3077/pr-7467

Backported as #7474

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

felixfontein · 2023-11-03T23:41:39Z

@Wihrt thanks a lot for your contribution!
@nejch @lgatellier thanks a lot for reviewing this!

fix: Fix gitlab constants calls Co-authored-by: Arnaud Hatzenbuhler <arnaud.hatzenbuhler@conserto.pro> (cherry picked from commit a366318)

…calls (#7474) [gitlab] Fix gitlab constants calls (#7467) fix: Fix gitlab constants calls Co-authored-by: Arnaud Hatzenbuhler <arnaud.hatzenbuhler@conserto.pro> (cherry picked from commit a366318) Co-authored-by: Arnaud Hatzenbuhler <arnaud.hatzenbuhler@gmail.com>

…calls (#7473) [gitlab] Fix gitlab constants calls (#7467) fix: Fix gitlab constants calls Co-authored-by: Arnaud Hatzenbuhler <arnaud.hatzenbuhler@conserto.pro> (cherry picked from commit a366318) Co-authored-by: Arnaud Hatzenbuhler <arnaud.hatzenbuhler@gmail.com>

patchback · 2023-11-04T11:27:01Z

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/a366318ac683303d05e14d4a7cbac9c7e2fe3077/pr-7467

Backported as #7475

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

fix: Fix gitlab constants calls Co-authored-by: Arnaud Hatzenbuhler <arnaud.hatzenbuhler@conserto.pro> (cherry picked from commit a366318)

…calls (#7475) [gitlab] Fix gitlab constants calls (#7467) fix: Fix gitlab constants calls Co-authored-by: Arnaud Hatzenbuhler <arnaud.hatzenbuhler@conserto.pro> (cherry picked from commit a366318) Co-authored-by: Arnaud Hatzenbuhler <arnaud.hatzenbuhler@gmail.com>

ansibullbot added docs docs_only module module new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Nov 3, 2023

nejch reviewed Nov 3, 2023

View reviewed changes

ansibullbot removed docs_only needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR small_patch Hopefully easy to review labels Nov 3, 2023

Wihrt changed the title ~~[gitlab_user] Specify the version constraint for python-gitlab module~~ [gitlab] Fix gitlab constants calls Nov 3, 2023

ansibullbot added the bug This issue/PR relates to a bug label Nov 3, 2023

lgatellier reviewed Nov 3, 2023

View reviewed changes

changelogs/fragments/7467-fix-gitlab-constants-calls.yml Outdated Show resolved Hide resolved

lgatellier reviewed Nov 3, 2023

View reviewed changes

plugins/modules/gitlab_protected_branch.py Outdated Show resolved Hide resolved

fix: Fix gitlab constants calls

04b69e5

Wihrt force-pushed the docs/gitlab_user_patch branch from 4ecb193 to 04b69e5 Compare November 3, 2023 16:29

lgatellier approved these changes Nov 3, 2023

View reviewed changes

felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-7 backport-8 Automatically create a backport for the stable-8 branch labels Nov 3, 2023

felixfontein merged commit a366318 into ansible-collections:main Nov 3, 2023

felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Nov 3, 2023

patchback bot pushed a commit that referenced this pull request Nov 3, 2023

[gitlab] Fix gitlab constants calls (#7467)

821d776

fix: Fix gitlab constants calls Co-authored-by: Arnaud Hatzenbuhler <arnaud.hatzenbuhler@conserto.pro> (cherry picked from commit a366318)

patchback bot mentioned this pull request Nov 3, 2023

[PR #7467/a366318a backport][stable-7] [gitlab] Fix gitlab constants calls #7473

Merged

patchback bot pushed a commit that referenced this pull request Nov 3, 2023

[gitlab] Fix gitlab constants calls (#7467)

e93a44e

fix: Fix gitlab constants calls Co-authored-by: Arnaud Hatzenbuhler <arnaud.hatzenbuhler@conserto.pro> (cherry picked from commit a366318)

patchback bot mentioned this pull request Nov 3, 2023

[PR #7467/a366318a backport][stable-8] [gitlab] Fix gitlab constants calls #7474

Merged

felixfontein added the backport-6 label Nov 4, 2023

patchback bot pushed a commit that referenced this pull request Nov 4, 2023

[gitlab] Fix gitlab constants calls (#7467)

60a36ca

fix: Fix gitlab constants calls Co-authored-by: Arnaud Hatzenbuhler <arnaud.hatzenbuhler@conserto.pro> (cherry picked from commit a366318)

patchback bot mentioned this pull request Nov 4, 2023

[PR #7467/a366318a backport][stable-6] [gitlab] Fix gitlab constants calls #7475

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[gitlab] Fix gitlab constants calls #7467

[gitlab] Fix gitlab constants calls #7467

Wihrt commented Nov 3, 2023 •

edited

Loading

ansibullbot commented Nov 3, 2023

nejch Nov 3, 2023

Wihrt Nov 3, 2023 •

edited

Loading

lgatellier Nov 3, 2023

Wihrt Nov 3, 2023

lgatellier commented Nov 3, 2023 •

edited

Loading

Wihrt commented Nov 3, 2023

lgatellier commented Nov 3, 2023 •

edited

Loading

patchback bot commented Nov 3, 2023 •

edited

Loading

patchback bot commented Nov 3, 2023 •

edited

Loading

felixfontein commented Nov 3, 2023

patchback bot commented Nov 4, 2023 •

edited

Loading

[gitlab] Fix gitlab constants calls #7467

[gitlab] Fix gitlab constants calls #7467

Conversation

Wihrt commented Nov 3, 2023 • edited Loading

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

ansibullbot commented Nov 3, 2023

nejch Nov 3, 2023

Choose a reason for hiding this comment

Wihrt Nov 3, 2023 • edited Loading

Choose a reason for hiding this comment

lgatellier Nov 3, 2023

Choose a reason for hiding this comment

Wihrt Nov 3, 2023

Choose a reason for hiding this comment

lgatellier commented Nov 3, 2023 • edited Loading

Wihrt commented Nov 3, 2023

lgatellier commented Nov 3, 2023 • edited Loading

patchback bot commented Nov 3, 2023 • edited Loading

Backport to stable-7: 💚 backport PR created

patchback bot commented Nov 3, 2023 • edited Loading

Backport to stable-8: 💚 backport PR created

felixfontein commented Nov 3, 2023

patchback bot commented Nov 4, 2023 • edited Loading

Backport to stable-6: 💚 backport PR created

Wihrt commented Nov 3, 2023 •

edited

Loading

Wihrt Nov 3, 2023 •

edited

Loading

lgatellier commented Nov 3, 2023 •

edited

Loading

lgatellier commented Nov 3, 2023 •

edited

Loading

patchback bot commented Nov 3, 2023 •

edited

Loading

patchback bot commented Nov 3, 2023 •

edited

Loading

patchback bot commented Nov 4, 2023 •

edited

Loading